Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating cluster-version-operator builder & base images to be consistent with ART #468

Merged
merged 1 commit into from Oct 8, 2020
Merged

Updating cluster-version-operator builder & base images to be consistent with ART #468

merged 1 commit into from Oct 8, 2020

Conversation

jupierce
Copy link
Contributor

@jupierce jupierce commented Oct 7, 2020 •
edited

Updating cluster-version-operator builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/f66c03011773dc3755ad874fc691be612914d65f/images/cluster-version-operator.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

Depends on openshift/images#44 . Allow it to merge and then run /test all on this PR.

@jupierce jupierce force-pushed the art-consistency-openshift-4.7-cluster-version-operator branch from b354c95 to 7cb2662 Compare October 7, 2020 15:42
@sdodson
Copy link
Member

sdodson commented Oct 7, 2020

/lgtm
@jupierce In general should we avoid touching the FROM on these files? I'm just curious where the deviation came in

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Oct 8, 2020

I'm just curious where the deviation came in

Deviation is just ART tracking the 4.6/4.7 master transition, so probably something we accept whenever ART makes a change like that.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6d9776c into openshift:master Oct 8, 2020
wking added a commit to wking/cincinnati-operator that referenced this pull request Nov 16, 2020
@wking
Dockerfile: Bump builder to ART's Go 1.15 image
6d8e674 
The outgoing docker.io image was subject to docker.io rate limiting
[1]:

  error: build error: failed to pull image: After retrying 2 times, Pull image still failed due to error: while pulling "docker://docker.io/openshift/origin-release:golang-1.13" as "docker.io/openshift/origin-release:golang-1.13"...

The new image matches openshift/cluster-version-operator@7cb2662924
(Updating cluster-version-operator builder & base images to be
consistent with ART, 2020-10-07,
openshift/cluster-version-operator#468).  Matching builders with the
CVO reduces our exposure by consolidating around a smaller set of Go
builder images.

[1]: openshift#82 (comment)
@wking wking mentioned this pull request Nov 16, 2020
Merged
wking added a commit to wking/cincinnati-operator that referenced this pull request Nov 16, 2020
@wking
Dockerfile: Bump builder to ART's Go 1.15 image
e8eb06e 
The outgoing docker.io image was subject to docker.io rate limiting
[1]:

  error: build error: failed to pull image: After retrying 2 times, Pull image still failed due to error: while pulling "docker://docker.io/openshift/origin-release:golang-1.13" as "docker.io/openshift/origin-release:golang-1.13"...

The new image matches openshift/cluster-version-operator@7cb2662924
(Updating cluster-version-operator builder & base images to be
consistent with ART, 2020-10-07,
openshift/cluster-version-operator#468).  Matching builders with the
CVO reduces our exposure by consolidating around a smaller set of Go
builder images.

I expect that after this lands, openshift/registry will pick it up via
a change like openshift/release@d0fa1c98b9 (Registry-replacer
autocommit, 2020-10-07, openshift/release#12532).

[1]: openshift#82 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@sdodson sdodson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jupierce @sdodson @openshift-ci-robot @openshift-bot @wking @openshift-merge-robot