Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1896584: pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires #480

Merged
merged 1 commit into from Nov 13, 2020
Merged

[release-4.6] Bug 1896584: pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires #480

merged 1 commit into from Nov 13, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #477

/assign wking

@wking
pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires
42d3c6d 
Apparently there's something in the HTTPS server goroutine that can
hang up even if we've called Shutdown() on the server [1].  Defend
against that with a safety valve to abandon stuck goroutines if
shutdownContext expires.

Also pivot to resultChannel and asyncResult, so we can get names for
the collected channels (and more easily identify the stuck channels by
elimination), following the pattern set by cc1921d (pkg/start:
Release leader lease on graceful shutdown, 2020-08-03, openshift#424).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1891143#c1
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1891143 has been cloned as Bugzilla bug 1896584. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1896584: pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires

In response to this:

[release-4.6] Bug 1891143: pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1891143: pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires [release-4.6] Bug 1896584: pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires Nov 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 11, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1896584, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1891143 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1891143 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

[release-4.6] Bug 1896584: pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Nov 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2020
@wking
Copy link
Member

wking commented Nov 11, 2020

/test e2e-metal-assisted

@openshift-ci-robot
Copy link
Contributor

@wking: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-agnostic
  • /test e2e-agnostic-upgrade
  • /test gofmt
  • /test images
  • /test integration
  • /test unit

Use /test all to run all jobs.

In response to this:

/test e2e-metal-assisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Nov 11, 2020 •
edited

Unrelated unit race and GCP install Service account ... does not exist.

/retest

@romfreiman
Copy link

@YuviGold maybe we need to move assisted release pr to 4.6?

@YuviGold
Copy link

@YuviGold maybe we need to move assisted release pr to 4.6?

@romfreiman
I updated the cvo-master configuration which is duplicated to the ongoing release configurations - 4.7, 4.8.
Since this PR is to the release-4.6 it triggers the old configuration without the e2e-metal-assisted test.
I will try to add it.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@YuviGold YuviGold mentioned this pull request Nov 11, 2020
Closed
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 12, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 39a4256 into openshift:release-4.6 Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1896584 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1896584: pkg/cvo/metrics: Abandon child goroutines after shutdownContext expires

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wking wking Awaiting requested review from wking

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @wking @romfreiman @YuviGold @openshift-bot @mrunalp @openshift-merge-robot