Bug 1976307: add ImageStreams manifest delete annotation logic

[jottofar]

No description provided.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 1976307, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1976307: add ImageStreams manifest delete annotation logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/bugzilla refresh

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 1976307, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianlinliu

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

This PR is needed by
openshift/cluster-samples-operator#380

[jottofar]

/retest

[wking]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[LalatenduMohanty]

Can we add an unit test for this?

[jottofar]

Can we add an unit test for this?

There are no unit tests specific to resource type, e.g. imagestreams vs. deployments. There's only the generic delete annotation unit tests in lib/resourcedelete/helper_test.go which this mod doesn't affect.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[jottofar]

Can we add an unit test for this?

Actually, thinking about this more, you're probably asking "can we add a unit test that would've caught this issue". Probably so but I don't think there's anything there now to "build on" but I'll look again to see what can be done.

[jottofar]

you're probably asking "can we add a unit test that would've caught this issue"

I looked at this when I originally added the resourcedelete package. There were no Unit tests for resourcebuilder and what I wanted for a Unit test then, and needs to be tested now to have caught this issue, is a test at the resourcebuilder Do method level. But I don't see a good way to do that, i.e. one which does not involve running on a cluster.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@jottofar: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#618

Bugzilla bug 1976307 has been moved to the MODIFIED state.

In response to this:

Bug 1976307: add ImageStreams manifest delete annotation logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.