Bug 1978774: pkg/cvo/egress: Load HTTPS proxy from Proxy status

[wking]

Since 4.2's ea5e3bc (#219), the CVO has been loading proxy config from the spec property. We should be loading from status instead, so we benefit from the network operator's validation. Risk is small, because unlike some other in-cluster components, the CVO is unlikely to break things if it is temporarily consuming a broken proxy configuration.

This is similar to c9fab43 (#311), where we moved our trusted CA source from the user-configured ConfigMap to the network-operator-validated ConfigMap.

[openshift-ci]

@wking: This pull request references Bugzilla bug 1978774, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianlinliu

In response to this:

Bug 1978774: pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@wking: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#621

Bugzilla bug 1978774 has been moved to the MODIFIED state.

In response to this:

Bug 1978774: pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palonsoro]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@palonsoro: #621 failed to apply on top of branch "release-4.8":

Applying: pkg/cvo/egress: Load HTTPS proxy from Proxy status
Using index info to reconstruct a base tree...
M	pkg/cvo/egress.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cvo/egress.go
CONFLICT (content): Merge conflict in pkg/cvo/egress.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 pkg/cvo/egress: Load HTTPS proxy from Proxy status
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.