Bug 2014165: pkg/cvo/egress: Load HTTPS proxy from Proxy status

[openshift-cherrypick-robot]

This is an automated cherry-pick of #627

/assign palonsoro

[openshift-ci]

@openshift-cherrypick-robot: Bugzilla bug 1980411 has been cloned as Bugzilla bug 2014170. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 2014170: [release-4.8] pkg/cvo/egress: Load HTTPS proxy from Proxy status

In response to this:

[release-4.6] Bug 1980411: [release-4.8] pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2014170, which is invalid:

• expected dependent Bugzilla bug 1980411 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 2014170: [release-4.8] pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palonsoro]

/retitle Bug 2014165: pkg/cvo/egress: Load HTTPS proxy from Proxy status

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2014165, which is invalid:

• expected dependent Bugzilla bug 2014170 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
• expected dependent Bugzilla bug 2014170 to target a release in 4.7.0, 4.7.z, but it targets "4.6.z" instead
• expected dependent Bugzilla bug 1980411 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2014165: pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palonsoro]

/bugzilla refresh

[openshift-ci]

@palonsoro: This pull request references Bugzilla bug 2014165, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2007674 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2007674 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/lgtm

[LalatenduMohanty]

/backport-risk-assessed

[LalatenduMohanty]

/label backport-risk-assessed

[jianlinliu]

/label qe-approved

[jianlinliu]

/lgtm

[jianlinliu]

/bugzilla cc-qa

[openshift-ci]

@jianlinliu: This pull request references Bugzilla bug 2014165, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2007674 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2007674 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jianlinliu]

Verified this bug with pre-merge build, and PASS

[root@preserve-jialiu-ansible ~]# oc get co network
NAME      VERSION                                                  AVAILABLE   PROGRESSING   DEGRADED   SINCE
network   4.6.0-0.ci.test-2021-10-15-022413-ci-ln-blf1xq2-latest   True        False         False      98m

[root@preserve-jialiu-ansible ~]# oc patch proxies.config.openshift.io/cluster --patch '{"spec":{"httpProxy":"testing"}}' --type=merge
proxy.config.openshift.io/cluster patched

[root@preserve-jialiu-ansible ~]# oc patch proxies.config.openshift.io/cluster --patch '{"spec":{"httpsProxy":"testing"}}' --type=merge
proxy.config.openshift.io/cluster patched

[root@preserve-jialiu-ansible ~]# oc get proxies.config.openshift.io cluster -o json
{
    "apiVersion": "config.openshift.io/v1",
    "kind": "Proxy",
    "metadata": {
        "creationTimestamp": "2021-10-15T02:55:49Z",
        "generation": 3,
        "name": "cluster",
        "resourceVersion": "49092",
        "selfLink": "/apis/config.openshift.io/v1/proxies/cluster",
        "uid": "3b8e2941-c109-4021-8b2d-7f79df800dc1"
    },
    "spec": {
        "httpProxy": "testing",
        "httpsProxy": "testing",
        "noProxy": "test.no-proxy.com",
        "trustedCA": {
            "name": ""
        }
    },
    "status": {
        "httpProxy": "http://proxy-user1:xxxx@ec2-18-119-134-28.us-east-2.compute.amazonaws.com:3128",
        "httpsProxy": "http://proxy-user1:xxxxx@ec2-18-119-134-28.us-east-2.compute.amazonaws.com:3128",
        "noProxy": ".cluster.local,.svc,.us-east-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.jialiu46.qe.devcluster.openshift.com,etcd-0.jialiu46.qe.devcluster.openshift.com,etcd-1.jialiu46.qe.devcluster.openshift.com,etcd-2.jialiu46.qe.devcluster.openshift.com,localhost,test.no-proxy.com"
    }
}


[root@preserve-jialiu-ansible ~]# oc get co network
NAME      VERSION                                                  AVAILABLE   PROGRESSING   DEGRADED   SINCE
network   4.6.0-0.ci.test-2021-10-15-022413-ci-ln-blf1xq2-latest   True        False         True       101m


[root@preserve-jialiu-ansible ~]# oc describe co network
Name:         network
Namespace:    
Labels:       <none>
Annotations:  network.operator.openshift.io/last-seen-state: {"DaemonsetStates":[],"DeploymentStates":[]}
API Version:  config.openshift.io/v1
Kind:         ClusterOperator
<--snip-->
Status:
  Conditions:
    Last Transition Time:  2021-10-15T04:45:24Z
    Message:               The configuration is invalid for proxy 'cluster' (invalid httpProxy URI: parse "testing": invalid URI for request). Use 'oc edit proxy.config.openshift.io cluster' to fix.
    Reason:                InvalidProxyConfig
    Status:                True
    Type:                  Degraded
    Last Transition Time:  2021-10-15T03:03:46Z
    Status:                True
    Type:                  Upgradeable
    Last Transition Time:  2021-10-15T03:15:19Z
    Status:                False
    Type:                  Progressing
    Last Transition Time:  2021-10-15T03:04:42Z
    Status:                True
    Type:                  Available
  Extension:               <nil>
<--snip-->

[root@preserve-jialiu-ansible ~]# oc adm upgrade
Cluster version is 4.6.0-0.ci.test-2021-10-15-022413-ci-ln-blf1xq2-latest

Upstream: https://api.openshift.com/api/upgrades_info/v1/graph
Channel: stable-4.6
warning: Cannot display available updates:
  Reason: VersionNotFound
  Message: Unable to retrieve available updates: currently reconciling cluster version 4.6.0-0.ci.test-2021-10-15-022413-ci-ln-blf1xq2-latest not found in the "stable-4.6" channel

CVO does not complain about the proxy URI, using status for that.

[openshift-ci]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#673

Bugzilla bug 2014165 has been moved to the MODIFIED state.

In response to this:

Bug 2014165: pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.