Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2014165: pkg/cvo/egress: Load HTTPS proxy from Proxy status #673

Commits on Oct 14, 2021

  1. pkg/cvo/egress: Load HTTPS proxy from Proxy status

    Since 4.2's ea5e3bc (Add http transport for cincinnati to enable
    proxy, 2019-07-16, openshift#219), the CVO has been loading proxy config from
    the spec property.  We should be loading from status instead, so we
    benefit from the network operator's validation.  Risk is small,
    because unlike some other in-cluster components, the CVO is unlikely
    to break things if it is temporarily consuming a broken proxy
    configuration.
    
    This is similar to c9fab43 (pkg/cvo: Fetch proxy CA certs from
    openshift-config-managed/trusted-ca-bundle, 2020-01-31, openshift#311), where
    we moved our trusted CA source from the user-configured ConfigMap to
    the network-operator-validated ConfigMap.
    palonsoro authored and openshift-cherrypick-robot committed Oct 14, 2021
    Copy the full SHA
    2ba3021 View commit details
    Browse the repository at this point in the history