-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2034484: Library go bump #716
Bug 2034484: Library go bump #716
Conversation
Generated with: $ go get github.com/openshift/library-go $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.17.3 linux/amd64
Catching up with [1]. [1]: kubernetes/kubernetes#105979
bd0ed99
to
efabb58
Compare
/retest-required |
2 similar comments
/retest-required |
/retest-required |
/approve Trevor, please pull the hold if this looks good to you as well |
Ok, I think I've wrapped my head around this, and the changes break down like:
I think those should be separate commits, and my just-updated #710 covers the first three points as a no-functional-change vendor bump. That would leave this pull request for the final |
Because ObjectReflectDiff is deprecated and doesn't handle the internal 'id' property. We're using the recommended replacement [1]. [1]: https://github.com/kubernetes/apimachinery/blob/de7147de41c9331e4697399f48564f1d970cc01e/pkg/util/diff/diff.go#L70
Now that we're using these in the pkg/payload unit tests. Generated with: $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.17.3 linux/amd64
edc3628
to
666d502
Compare
leader election configs are now delegated to library-go and are topology aware integration test was updated to set the new leader election configs ran: go mod tidy && go mod vendor && go mod verify Signed-off-by: ehila <ehila@redhat.com>
666d502
to
a6ec7eb
Compare
|
||
if infra, err := clusterstatus.GetClusterInfraStatus(ctx, restcfg); err == nil && infra != nil { | ||
if infra.ControlPlaneTopology == configv1.SingleReplicaTopologyMode { | ||
return libgoleaderelection.LeaderElectionSNOConfig(defaultLeaderElection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not all that particular about our lease settings, and we do have reasonably solid graceful shutdown logic where we release the leases when termination gives us enough time to do that. So I'm personally fine simplifying all of this and just using libgoleaderelection.LeaderElectionSNOConfig
all the time, regardless of the Infrastructure configuration. Thoughts?
/retest |
@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
/lgtm
etcd leader election and PDB issues are unrelated:
/override ci/prow/e2e-agnostic-upgrade
KubePersistentVolumeErrors
are unrelated:
/override ci/prow/e2e-agnostic
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic, ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@eggfoobar: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2034484 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.
Changes: