Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1951835: Handle report only sync errors #837

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Bug 1951835: Handle report only sync errors #837

merged 1 commit into from
Sep 28, 2022

Conversation

jottofar
Copy link
Contributor

@jottofar jottofar commented Sep 13, 2022 •
edited
Loading

that are returned as UpdateEffectReport during payload initialization by allowing payload initialization to complete successfully and setting the ClusterStatusFailing condition.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2022

@jottofar: This pull request references Bugzilla bug 1951835, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @shellyyang1989

In response to this:

WIP: Bug 1951835: Handle report only sync errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@jottofar jottofar force-pushed the bug-1951835-fix branch 7 times, most recently from ffe306f to cfeef18 Compare September 15, 2022 19:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

@jottofar: This pull request references Bugzilla bug 1951835, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @shellyyang1989

In response to this:

WIP: Bug 1951835: Handle report only sync errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jottofar
Copy link
Contributor Author

/retitle Bug 1951835: Handle report only sync errors

@openshift-ci openshift-ci bot changed the title WIP: Bug 1951835: Handle report only sync errors Bug 1951835: Handle report only sync errors Sep 15, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
@jottofar
Copy link
Contributor Author

/retest

@jottofar
Copy link
Contributor Author

/test e2e-agnostic-upgrade-out-of-change

2 similar comments
@jottofar
Copy link
Contributor Author

/test e2e-agnostic-upgrade-out-of-change

@jottofar
Copy link
Contributor Author

/test e2e-agnostic-upgrade-out-of-change

wking
wking reviewed Sep 21, 2022
View reviewed changes
pkg/cvo/sync_worker.go Outdated Show resolved Hide resolved
@jottofar jottofar force-pushed the bug-1951835-fix branch 3 times, most recently from 6b895e4 to 4bcdbdc Compare September 23, 2022 13:57
@jottofar
Copy link
Contributor Author

/retest

wking
wking reviewed Sep 23, 2022
View reviewed changes
pkg/cvo/sync_worker.go Outdated Show resolved Hide resolved
wking
wking reviewed Sep 23, 2022
View reviewed changes
pkg/cvo/sync_test.go Outdated Show resolved Hide resolved
wking
wking reviewed Sep 23, 2022
View reviewed changes
pkg/cvo/sync_worker.go Outdated Show resolved Hide resolved
@jottofar
Copy link
Contributor Author

/test unit

@jottofar
Copy link
Contributor Author

/test e2e-agnostic-upgrade-out-of-change

@jottofar
Copy link
Contributor Author

/override e2e-agnostic-upgrade-out-of-change

Known issue being followed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

@jottofar: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-agnostic-upgrade-out-of-change

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agnostic
  • ci/prow/e2e-agnostic-operator
  • ci/prow/e2e-agnostic-upgrade-into-change
  • ci/prow/e2e-agnostic-upgrade-out-of-change
  • ci/prow/gofmt
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/unit
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-operator
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade-into-change
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade-out-of-change
  • pull-ci-openshift-cluster-version-operator-master-gofmt
  • pull-ci-openshift-cluster-version-operator-master-images
  • pull-ci-openshift-cluster-version-operator-master-lint
  • pull-ci-openshift-cluster-version-operator-master-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-agnostic-upgrade-out-of-change

Known issue being followed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jottofar
Copy link
Contributor Author

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Known issue being followed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

@jottofar: Overrode contexts on behalf of jottofar: ci/prow/e2e-agnostic-upgrade-out-of-change

In response to this:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Known issue being followed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LalatenduMohanty
LalatenduMohanty approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,jottofar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e660bab into openshift:master Sep 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

@jottofar: All pull requests linked via external trackers have merged:

Bugzilla bug 1951835 has been moved to the MODIFIED state.

In response to this:

Bug 1951835: Handle report only sync errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@shellyyang1989 shellyyang1989 Awaiting requested review from shellyyang1989

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@LalatenduMohanty LalatenduMohanty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jottofar @wking @LalatenduMohanty @openshift-merge-robot