-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-2727: Do not fail precondition check for UnknownUpdate #856
OCPBUGS-2727: Do not fail precondition check for UnknownUpdate #856
Conversation
@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-2727, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-2727, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-2727, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-2727, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit |
076fe95
to
77c67e7
Compare
a1e9171
to
e6e8491
Compare
/test unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
"Unqualified" review, feel free to wait for another reviewer or unhold ;)
e6e8491
to
e6ee0b8
Compare
Squashed the commits in e6ee0b8 |
/test unit |
@wking: This pull request references Jira Issue OCPBUGS-2727, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-2727, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reason string | ||
Message string | ||
Name string | ||
NonBlockingWarning bool // For some errors we do not want to fail the precondition check but we want to communicate about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, this could be a godoc, instead of a non-structured comment, but 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-agnostic |
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@LalatenduMohanty: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@LalatenduMohanty: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-2727 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick 4.11 |
@LalatenduMohanty: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.11 |
@petr-muller: #856 failed to apply on top of branch "release-4.11":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.12 |
@LalatenduMohanty: new pull request created: #861 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid errors like: $ oc get -o json clusterversion version | jq -r '.status.history[0].acceptedRisks' Forced through blocking failures: Precondition "ClusterVersionRecommendedUpdate" failed because of "UnknownUpdate": RetrievedUpdates=True (), so the update from 4.13.0-0.okd-2022-12-11-064650 to 4.13.0-0.okd-2022-12-13-052859 is probably neither recommended nor supported. Instead, tweak the logic from 481bcde (OCPBUGS-2727: Do not fail precondition check for UnknownUpdate, 2022-10-21, openshift#856), and only append the "Forced through blocking failures:" prefix when the forcing was required.
Avoid errors like: $ oc get -o json clusterversion version | jq -r '.status.history[0].acceptedRisks' Forced through blocking failures: Precondition "ClusterVersionRecommendedUpdate" failed because of "UnknownUpdate": RetrievedUpdates=True (), so the update from 4.13.0-0.okd-2022-12-11-064650 to 4.13.0-0.okd-2022-12-13-052859 is probably neither recommended nor supported. Instead, tweak the logic from 481bcde (OCPBUGS-2727: Do not fail precondition check for UnknownUpdate, 2022-10-21, openshift#856), and only append the "Forced through blocking failures:" prefix when the forcing was required. Also fail-closed and treat non *Error errors as blocking too, where previously only !pferr.NonBlockingWarning were blocking.
Avoid errors like: $ oc get -o json clusterversion version | jq -r '.status.history[0].acceptedRisks' Forced through blocking failures: Precondition "ClusterVersionRecommendedUpdate" failed because of "UnknownUpdate": RetrievedUpdates=True (), so the update from 4.13.0-0.okd-2022-12-11-064650 to 4.13.0-0.okd-2022-12-13-052859 is probably neither recommended nor supported. Instead, tweak the logic from 481bcde (OCPBUGS-2727: Do not fail precondition check for UnknownUpdate, 2022-10-21, openshift#856), and only append the "Forced through blocking failures:" prefix when the forcing was required. Also fail-closed and treat non *Error errors as blocking too, where previously only !pferr.NonBlockingWarning were blocking.
Avoid errors like: $ oc get -o json clusterversion version | jq -r '.status.history[0].acceptedRisks' Forced through blocking failures: Precondition "ClusterVersionRecommendedUpdate" failed because of "UnknownUpdate": RetrievedUpdates=True (), so the update from 4.13.0-0.okd-2022-12-11-064650 to 4.13.0-0.okd-2022-12-13-052859 is probably neither recommended nor supported. Instead, tweak the logic from 481bcde (OCPBUGS-2727: Do not fail precondition check for UnknownUpdate, 2022-10-21, openshift#856), and only append the "Forced through blocking failures:" prefix when the forcing was required. Also fail-closed and treat non *Error errors as blocking too, where previously only !pferr.NonBlockingWarning were blocking.
With this change we will not fail precondition checks when a version is not in available updates. So users should be able to upgrade to any version with approriate client side overrides. For example using --allow-explicit-upgrade and --to-imge flags in "oc adm upgrade"
Signed-off-by: Lalatendu Mohanty lmohanty@redhat.com