-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't route CPUThrottlingHigh for redhat-.* ns to PD #91
Don't route CPUThrottlingHigh for redhat-.* ns to PD #91
Conversation
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 56.95% 57.06% +0.11%
==========================================
Files 8 8
Lines 388 389 +1
==========================================
+ Hits 221 222 +1
Misses 159 159
Partials 8 8
|
@@ -129,6 +129,8 @@ func createPagerdutyRoute() *alertmanager.Route { | |||
{Receiver: receiverNull, MatchRE: map[string]string{"namespace": alertmanager.PDRegexLP}, Match: map[string]string{"alertname": "PodDisruptionBudgetLimit"}}, | |||
// https://issues.redhat.com/browse/OSD-3973 | |||
{Receiver: receiverNull, MatchRE: map[string]string{"namespace": alertmanager.PDRegexLP}, Match: map[string]string{"alertname": "PodDisruptionBudgetAtLimit"}}, | |||
// https://issues.redhat.com/browse/OSD-4265, https://issues.redhat.com/browse/INTLY-8790 | |||
{Receiver: receiverNull, MatchRE: map[string]string{"namespace": alertmanager.PDRegexLP}, Match: map[string]string{"alertname": "CPUThrollingHigh"}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Throlling
the correct spelling?
/hold |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, fahlmant, jewzaam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/OSD-4265