Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WaitForSettledState func to check Operator Config before progressing #241

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Add WaitForSettledState func to check Operator Config before progressing #241

merged 1 commit into from
Jun 14, 2019

Conversation

benjaminapetersen
Copy link
Contributor

Add WaitForSettledState func to check Operator Config before progressing to next test.

/assign @jhadvig @zherman0

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2019
@benjaminapetersen benjaminapetersen force-pushed the testing/e2e/flakes/wait-for-settled branch from cc78a60 to 9a0c2e7 Compare June 11, 2019 19:09
jhadvig
jhadvig requested changes Jun 12, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, otherwise looks good 👍

pkg/testframework/console-operator.go Show resolved Hide resolved
pkg/testframework/console-operator.go Outdated Show resolved Hide resolved
pkg/testframework/console-operator.go Outdated Show resolved Hide resolved
@benjaminapetersen benjaminapetersen force-pushed the testing/e2e/flakes/wait-for-settled branch from 9a0c2e7 to fe96bc0 Compare June 12, 2019 14:23
@benjaminapetersen
Copy link
Contributor Author

@jhadvig changes made, thanks!

jhadvig
jhadvig approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjaminapetersen 👍
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

17 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jhadvig
Copy link
Member

jhadvig commented Jun 13, 2019

@benjaminapetersen some of the e2e tests re failing with

console-operator.go:256: operator has not reached settled state: timed out waiting for the condition

@jhadvig
Copy link
Member

jhadvig commented Jun 13, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2019
@benjaminapetersen
Copy link
Contributor Author

Specifically this bunch:

=== RUN   TestOperatorConfigBranding
--- FAIL: TestOperatorConfigBranding (28.47s)
    branding_test.go:69: update operator with okd
    branding_test.go:69: update operator with ocp
    branding_test.go:69: update operator with online
    branding_test.go:69: update operator with dedicated
    branding_test.go:69: update operator with azure
    console-operator.go:256: operator has not reached settled state: timed out waiting for the condition
=== RUN   TestBrandingFromManagedConfigMap
--- FAIL: TestBrandingFromManagedConfigMap (22.26s)
    branding_test.go:91: update data for the config map in openshift-config-managed namespace with okd
    branding_test.go:91: update data for the config map in openshift-config-managed namespace with ocp
    console-operator.go:256: operator has not reached settled state: timed out waiting for the condition
=== RUN   TestDebugLogLevel
--- FAIL: TestDebugLogLevel (24.45s)
    console-operator.go:66: console operator already in 'Managed' state
    console-operator.go:161: checking if console operator LogLevel is set to 'Normal'...
    console-operator.go:184: setting console operator to 'Normal' LogLevel ...
    console-operator.go:184: setting console operator to 'Debug' LogLevel ...
    logging_test.go:89: checking if '--log-level=*=DEBUG' flag is set on the console deployment container command...
    console-operator.go:256: operator has not reached settled state: timed out waiting for the condition
    console-operator.go:184: setting console operator to 'Normal' LogLevel ...
=== RUN   TestTraceLogLevel
--- FAIL: TestTraceLogLevel (23.33s)
    console-operator.go:66: console operator already in 'Managed' state
    console-operator.go:161: checking if console operator LogLevel is set to 'Normal'...
    console-operator.go:184: setting console operator to 'Trace' LogLevel ...
    logging_test.go:89: checking if '--log-level=*=TRACE' flag is set on the console deployment container command...
    console-operator.go:256: operator has not reached settled state: timed out waiting for the condition
    console-operator.go:184: setting console operator to 'Normal' LogLevel ...
=== RUN   TestTraceAllLogLevel
--- FAIL: TestTraceAllLogLevel (23.32s)
    console-operator.go:66: console operator already in 'Managed' state
    console-operator.go:161: checking if console operator LogLevel is set to 'Normal'...
    console-operator.go:184: setting console operator to 'TraceAll' LogLevel ...
    logging_test.go:89: checking if '--log-level=*=TRACE' flag is set on the console deployment container command...
    console-operator.go:256: operator has not reached settled state: timed out waiting for the condition
    console-operator.go:184: setting console operator to 'Normal' LogLevel ...
=== RUN   TestManaged
--- FAIL: TestManaged (25.32s)
    console-operator.go:66: console operator already in 'Managed' state
    framework.go:33: deleting console Deployment...
    framework.go:33: deleting console Service...
    framework.go:33: deleting console Route...
    framework.go:33: deleting console ConfigMap...
    managed_test.go:26: validating that the operator recreates resources when ManagementState:Managed...
    console-operator.go:256: operator has not reached settled state: timed out waiting for the condition
    console-operator.go:66: console operator already in 'Managed' state
=== RUN   TestEditManagedConfigMap
--- FAIL: TestEditManagedConfigMap (21.10s)
    console-operator.go:66: console operator already in 'Managed' state
    util.go:26: patching Data on the console ConfigMap
    util.go:33: polling for patched Data on the console ConfigMap
    console-operator.go:256: operator has not reached settled state: timed out waiting for the condition
    console-operator.go:66: console operator already in 'Managed' state

I'll increase the max again to see what we get.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@benjaminapetersen benjaminapetersen force-pushed the testing/e2e/flakes/wait-for-settled branch from e69d0e2 to 42c29e4 Compare June 13, 2019 17:10
@benjaminapetersen benjaminapetersen force-pushed the testing/e2e/flakes/wait-for-settled branch from 42c29e4 to 6df6ac3 Compare June 14, 2019 15:53
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 14, 2019
jhadvig
jhadvig approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@zherman0
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 22d9f0d into openshift:master Jun 14, 2019
@benjaminapetersen benjaminapetersen deleted the testing/e2e/flakes/wait-for-settled branch June 17, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

@zherman0 zherman0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@benjaminapetersen @openshift-bot @jhadvig @zherman0 @openshift-ci-robot @openshift-merge-robot