Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRUD (create,delete) tests for console extension resources #345

Merged

Conversation

benjaminapetersen
Copy link
Contributor

Since we are loading these resources from generated YAML in /vendor, lets make sure we can CREATE/DELETE one of each.

/assign @spadgett @jhadvig

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2019
@benjaminapetersen
Copy link
Contributor Author

/retest

level=fatal msg="Terraform destroy: failed to destroy using Terraform"

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, otherwise the tests are looking good 👍

test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
test/e2e/extensions_crud_test.go Outdated Show resolved Hide resolved
@benjaminapetersen
Copy link
Contributor Author

@jhadvig udpated, increased noise for all tests!

@jhadvig
Copy link
Member

jhadvig commented Nov 13, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 365e1e4 into openshift:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants