New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.4] Bug 1809667: The console should wait until it is out of rotation to shut down #387
Conversation
When a pod is marked deleted, endpoints are updated instantly and propagate to load balancers, routers, and nodes. A component that wishes to remain available during upgrades must wait longer than the default propagation interval for these changes to avoid having requests delivered to pods that are shutting down. Change the console to wait 25s before terminating the serving process and up to 40s on the node to ensure all front ends have time to drain. The minimum interval here is how long an average connection can take behind the router to drain, once new connections stop getting created. I.e. wait = time to propagate endpoints (5s) + time for router reload (5s) + time for longest request to finish (15s) = 25s
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1809665, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1809667, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@benjaminapetersen please review and approve for 4.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/retest
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1809667 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #385
/assign smarterclayton