Bug 1813775: Publish license file #439
Conversation
Publish the license file with oc binary on downloads-openshift-console since oc binary is applied Apache License 2.0. This depends on openshift/oc#337 to provide the license in cli-artifacts.
openshift-ci-robot
added
bugzilla/severity-medium
|
@jhadvig: This pull request references Bugzilla bug 1813775, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
| @@ -186,6 +186,11 @@ func PlatformBasedOCConsoleCLIDownloads(host, cliDownloadsName string) *v1.Conso | |||
| }) | |||
| } | |||
|
|
|||
| links = append(links, v1.CLIDownloadLink{ | |||
| Href: fmt.Sprintf("%s/oc-license", baseURL), | |||
| Text: fmt.Sprintf("Download LICENSE for OpenShift Command Line Interface"), | |||
There was a problem hiding this comment.
Maybe just "LICENSE"? Shouldn't need Sprintf
| Text: fmt.Sprintf("Download LICENSE for OpenShift Command Line Interface"), | |
| Text: "LICENSE", |
| @@ -135,6 +135,10 @@ The oc binary offers the same capabilities as the kubectl binary, but it is furt | |||
| Href: "https://www.example.com/s390x/linux/oc.tar", | |||
| Text: "Download oc for Linux for IBM Z (unsupported)", | |||
| }, | |||
| { | |||
| Href: "https://www.example.com/oc-license", | |||
| Text: "Download LICENSE for OpenShift Command Line Interface", | |||
There was a problem hiding this comment.
| Text: "Download LICENSE for OpenShift Command Line Interface", | |
| Text: "LICENSE", |
|
/cc @wking |
|
@spadgett comments addressed. Just FYI there is a |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jhadvig: Some pull requests linked via external trackers have merged: openshift/console-operator#439. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@jhadvig: new pull request created: #440 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Based on:
Addressing comments + rebasing on top of master and fixing tests, so we can start backport process.
Screen:
Not sure if it makes sense to backport all four commits, since my last on removes most of the added code. Would make the backport a lot easier.
/assign @spadgett