-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place apache license in cli-artifacts #337
Conversation
Places Apache License file in cli-artifacts since Apache License 2.0 requires to give a copy of the license, for example, when publishing binary on downloads-openshift-console.
Hi @eramoto. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Publish the license file with oc binary on downloads-openshift-console since oc binary is applied Apache License 2.0. This depends on openshift/oc#337 to provide the license in cli-artifacts.
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eramoto, sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Publish the license file with oc binary on downloads-openshift-console since oc binary is applied Apache License 2.0. This depends on openshift/oc#337 to provide the license in cli-artifacts.
Publish the license file with oc binary on downloads-openshift-console since oc binary is applied Apache License 2.0. This depends on openshift/oc#337 to provide the license in cli-artifacts.
/cherry-pick release-4.4 |
@jhadvig: new pull request created: #472 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.3 |
@jhadvig: new pull request created: #473 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Places Apache License file in cli-artifacts since Apache License 2.0
requires to give a copy of the license, for example, when publishing
binary on downloads-openshift-console.