Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place apache license in cli-artifacts #337

Merged
merged 1 commit into from Mar 20, 2020
Merged

Place apache license in cli-artifacts #337

merged 1 commit into from Mar 20, 2020

Conversation

eramoto
Copy link
Contributor

@eramoto eramoto commented Mar 4, 2020

Places Apache License file in cli-artifacts since Apache License 2.0
requires to give a copy of the license, for example, when publishing
binary on downloads-openshift-console.

@eramoto
Place apache license in cli-artifacts
caaf4d3 
Places Apache License file in cli-artifacts since Apache License 2.0
requires to give a copy of the license, for example, when publishing
binary on downloads-openshift-console.
@openshift-ci-robot
Copy link

Hi @eramoto. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2020
eramoto added a commit to eramoto/console-operator that referenced this pull request Mar 4, 2020
@eramoto
Publish license file of oc on downloads-openshift-console
65e1f87 
Publish the license file with oc binary on downloads-openshift-console
since oc binary is applied Apache License 2.0.

This depends on openshift/oc#337 to provide the license in cli-artifacts.
@eramoto eramoto mentioned this pull request Mar 4, 2020
Closed
@sallyom
Copy link
Contributor

sallyom commented Mar 19, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2020
@sallyom
Copy link
Contributor

sallyom commented Mar 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
soltysh
soltysh approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eramoto, sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ae5f58b into openshift:master Mar 20, 2020
jhadvig pushed a commit to jhadvig/console-operator that referenced this pull request Jun 15, 2020
@eramoto @jhadvig
Publish license file of oc on downloads-openshift-console
1f7f5d0 
Publish the license file with oc binary on downloads-openshift-console
since oc binary is applied Apache License 2.0.

This depends on openshift/oc#337 to provide the license in cli-artifacts.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/console-operator that referenced this pull request Jun 16, 2020
@eramoto
Publish license file of oc on downloads-openshift-console
9b377f2 
Publish the license file with oc binary on downloads-openshift-console
since oc binary is applied Apache License 2.0.

This depends on openshift/oc#337 to provide the license in cli-artifacts.
@spadgett spadgett mentioned this pull request Jun 22, 2020
Merged
@jhadvig
Copy link
Member

jhadvig commented Jun 22, 2020 •
edited

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

@jhadvig: new pull request created: #472

In response to this:

/cherry-pick release-4.4
/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Member

jhadvig commented Jun 22, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

@jhadvig: new pull request created: #473

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sallyom sallyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@eramoto @openshift-ci-robot @sallyom @openshift-bot @jhadvig @openshift-cherrypick-robot @soltysh @openshift-merge-robot