-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to upstream UI components and config #562
Conversation
/retest |
1 similar comment
/retest |
/test e2e-agnostic-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipgough sorry for the delay, was on PTO.
Thanks for removing all the places we are using the monitoring data + helper methods + tests.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, PhilipGough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-operator |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This change implements the first stage of deprecating upstream UI components that we no lonbger wish to support. See https://issues.redhat.com/browse/MON-1658 anmd related changes in openshift/console-operator#562 and openshift/console#9276
This is related to CMO-#1223 and Console-#9276
See the following epic for context https://issues.redhat.com/browse/MON-1591
cc @simonpasquier, @kyoto - obviously I'm not too familiar with the console repo's but I've gone through it and cannot see any other touch points. Any suggestions on the best way to test these three PR's e2e?