Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to upstream UI components and config #562

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Remove references to upstream UI components and config #562

merged 1 commit into from
Jul 17, 2021

Conversation

philipgough
Copy link
Contributor

@philipgough philipgough commented Jul 1, 2021

This is related to CMO-#1223 and Console-#9276

See the following epic for context https://issues.redhat.com/browse/MON-1591

cc @simonpasquier, @kyoto - obviously I'm not too familiar with the console repo's but I've gone through it and cannot see any other touch points. Any suggestions on the best way to test these three PR's e2e?

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett July 1, 2021 15:11
@philipgough
Copy link
Contributor Author

/retest

1 similar comment
@philipgough
Copy link
Contributor Author

/retest

@jhadvig
Copy link
Member

jhadvig commented Jul 15, 2021

/test e2e-agnostic-upgrade

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philipgough sorry for the delay, was on PTO.
Thanks for removing all the places we are using the monitoring data + helper methods + tests.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, PhilipGough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@jhadvig
Copy link
Member

jhadvig commented Jul 16, 2021

/test e2e-aws-operator

@philipgough
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2d05f95 into openshift:master Jul 17, 2021
@philipgough philipgough deleted the MON-1658 branch July 19, 2021 09:07
philipgough added a commit to philipgough/cluster-monitoring-operator that referenced this pull request Jul 19, 2021
This change implements the first stage of deprecating upstream UI
components that we no lonbger wish to support.

See https://issues.redhat.com/browse/MON-1658 anmd related changes in
openshift/console-operator#562 and
openshift/console#9276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants