Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33021, TRT-1623: Revert "Merge pull request #889 from jhadvig/CONSOLE-4014" #892

Merged

Conversation

xueqzhan
Copy link
Contributor

TRT has unfortunately had to revert this breaking change to get CI and/or nightly payloads flowing again.

The original PR was #889.

This broke hypershift e2e. See slack thread for more info: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1714055997244269

To restore your change, create a new PR that reverts the revert and layers additional separate commit(s) on top that addresses the problem.

Please run /payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3 and make sure all three job runs pass before merging the unrevert.

Contact information for TRT is available at https://source.redhat.com/groups/public/atomicopenshift/atomicopenshift_wiki/how_to_contact_the_technical_release_team. Please reach out if you need assistance in relanding your change or have feedback about this process.

This reverts commit 240c618, reversing
changes made to 3bc8c96.
@openshift-ci openshift-ci bot requested review from jhadvig and spadgett April 25, 2024 15:30
@xueqzhan
Copy link
Contributor Author

/retest ci/prow/e2e-aws-console

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@xueqzhan: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws-console
  • /test e2e-aws-operator
  • /test e2e-azure-ovn-upgrade
  • /test e2e-gcp-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ovn-single-node

Use /test all to run all jobs.

In response to this:

/retest ci/prow/e2e-aws-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xueqzhan
Copy link
Contributor Author

/test ci/prow/e2e-aws-console

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@xueqzhan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-console
  • /test e2e-aws-operator
  • /test e2e-azure-ovn-upgrade
  • /test e2e-gcp-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ovn-single-node

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-aws-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xueqzhan
Copy link
Contributor Author

/test e2e-aws-console

@neisw
Copy link
Contributor

neisw commented Apr 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neisw, xueqzhan
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neisw
Copy link
Contributor

neisw commented Apr 25, 2024

/override ci/prow/e2e-aws-console
/label approved
/label docs-approved

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR labels Apr 25, 2024
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-console

In response to this:

/override ci/prow/e2e-aws-console
/label approved
/label docs-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neisw
Copy link
Contributor

neisw commented Apr 25, 2024

TRT-1623

/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Apr 25, 2024
@neisw
Copy link
Contributor

neisw commented Apr 25, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@neisw: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xueqzhan xueqzhan changed the title Revert "Merge pull request #889 from jhadvig/CONSOLE-4014" TRT-1623: Revert "Merge pull request #889 from jhadvig/CONSOLE-4014" Apr 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 25, 2024

@xueqzhan: This pull request references TRT-1623 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

TRT has unfortunately had to revert this breaking change to get CI and/or nightly payloads flowing again.

The original PR was #889.

This broke hypershift e2e. See slack thread for more info: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1714055997244269

To restore your change, create a new PR that reverts the revert and layers additional separate commit(s) on top that addresses the problem.

Please run /payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3 and make sure all three job runs pass before merging the unrevert.

Contact information for TRT is available at https://source.redhat.com/groups/public/atomicopenshift/atomicopenshift_wiki/how_to_contact_the_technical_release_team. Please reach out if you need assistance in relanding your change or have feedback about this process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xueqzhan
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 25, 2024

@xueqzhan: This pull request references TRT-1623 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit dac8cc8 into openshift:master Apr 25, 2024
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-operator-container-v4.17.0-202404251943.p0.gdac8cc8.assembly.stream.el9 for distgit openshift-enterprise-console-operator.
All builds following this will include this PR.

@jhadvig jhadvig changed the title TRT-1623: Revert "Merge pull request #889 from jhadvig/CONSOLE-4014" OCPBUGS-33021, TRT-1623: Revert "Merge pull request #889 from jhadvig/CONSOLE-4014" Apr 30, 2024
@jhadvig
Copy link
Member

jhadvig commented Apr 30, 2024

/jira refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants