New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-4014: Pass OCM organization ID and OCP cluster ID to console-config.yaml #893
Conversation
@jhadvig: This pull request references CONSOLE-4014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-bm |
/payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3 |
@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a77ba20-0342-11ef-9c5b-1755c827dd18-0 |
@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/597b4370-0342-11ef-90c2-aa211ff9378d-0 |
/retest |
flakes |
/retest |
/retest |
@jhadvig: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3 |
@jhadvig: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d604b10-06b2-11ef-9208-9bbef529efbd-0 |
periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn failed with:
/payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3 |
@jhadvig: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/992a60e0-06ea-11ef-8067-71ac812dd637-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. Please ensure that /payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3
runs successfully.
/lgtm
/payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3 |
@jerolimov: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3f66d4e0-087e-11ef-90bc-b3351d20b02c-0 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding tags manually since the QE already tested the change. Also discussed the results of the additional TCs with @sjenning https://redhat-internal.slack.com/archives/C01CQA76KMX/p1714665332657349?thread_ts=1714055997.244269&cid=C01CQA76KMX |
@jhadvig: This pull request references CONSOLE-4014 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-operator-container-v4.16.0-202405021917.p0.g0120ab8.assembly.stream.el9 for distgit openshift-enterprise-console-operator. |
Updating console-operator to get:
clusterID
- from the clusterversionversion
resourceorganizationID
- from the OCM accountmanager API by passing clusterID and pull-secret forcloud.openshift.com
Refactored the sync_400 to have a single
GetTelemeterConfiguration
metyod which will be responsible for assembling the telemetry configuration.Needed to reopen the PR due to revert, which was causing Hypershift issues.
/assign @TheRealJon
@jerolimov FYI