Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-4014: Pass OCM organization ID and OCP cluster ID to console-config.yaml #893

Merged
merged 2 commits into from May 2, 2024

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Apr 25, 2024

Updating console-operator to get:

  • clusterID - from the clusterversion version resource
  • organizationID - from the OCM accountmanager API by passing clusterID and pull-secret for cloud.openshift.com

Refactored the sync_400 to have a single GetTelemeterConfiguration metyod which will be responsible for assembling the telemetry configuration.

Needed to reopen the PR due to revert, which was causing Hypershift issues.

/assign @TheRealJon

@jerolimov FYI

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 25, 2024

@jhadvig: This pull request references CONSOLE-4014 which is a valid jira issue.

In response to this:

Updating console-operator to get:

  • clusterID - from the clusterversion version resource
  • organizationID - from the OCM accountmanager API by passing clusterID and pull-secret for cloud.openshift.com

Refactored the sync_400 to have a single GetTelemeterConfiguration metyod which will be responsible for assembling the telemetry configuration.

Needed to reopen the PR due to revert, which was causing Hypershift issues.

/assign @TheRealJon

@jerolimov FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@neisw
Copy link
Contributor

neisw commented Apr 25, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-bm

@neisw
Copy link
Contributor

neisw commented Apr 25, 2024

/payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a77ba20-0342-11ef-9c5b-1755c827dd18-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/597b4370-0342-11ef-90c2-aa211ff9378d-0

@jhadvig
Copy link
Member Author

jhadvig commented Apr 26, 2024

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Apr 26, 2024

flakes
/retest

@jhadvig
Copy link
Member Author

jhadvig commented Apr 26, 2024

│ ✖  crd-extensions/console-notification      01:27        1        -        1        -        - │
  │    .cy.ts                                                                                      │

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Apr 29, 2024

crd-extensions/console-yaml-sample.      01:28        1        -        1        -        -   │    cy.ts   

/retest

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jhadvig
Copy link
Member Author

jhadvig commented Apr 30, 2024

/payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@jhadvig: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d604b10-06b2-11ef-9208-9bbef529efbd-0

@jhadvig
Copy link
Member Author

jhadvig commented Apr 30, 2024

periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn failed with:

{  failed to create secret: secrets "release-analysis-prpqr-aggregator" already exists}

/payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@jhadvig: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/992a60e0-06ea-11ef-8067-71ac812dd637-0

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Please ensure that /payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3 runs successfully.

/lgtm

@jerolimov
Copy link
Member

/payload-aggregate periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn 3

Copy link
Contributor

openshift-ci bot commented May 2, 2024

@jerolimov: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3f66d4e0-087e-11ef-90bc-b3351d20b02c-0

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
Copy link
Contributor

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member Author

jhadvig commented May 2, 2024

Adding tags manually since the QE already tested the change.

Also discussed the results of the additional TCs with @sjenning https://redhat-internal.slack.com/archives/C01CQA76KMX/p1714665332657349?thread_ts=1714055997.244269&cid=C01CQA76KMX

@jhadvig jhadvig added qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels May 2, 2024
@jhadvig jhadvig added the docs-approved Signifies that Docs has signed off on this PR label May 2, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 2, 2024

@jhadvig: This pull request references CONSOLE-4014 which is a valid jira issue.

In response to this:

Updating console-operator to get:

  • clusterID - from the clusterversion version resource
  • organizationID - from the OCM accountmanager API by passing clusterID and pull-secret for cloud.openshift.com

Refactored the sync_400 to have a single GetTelemeterConfiguration metyod which will be responsible for assembling the telemetry configuration.

Needed to reopen the PR due to revert, which was causing Hypershift issues.

/assign @TheRealJon

@jerolimov FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 0120ab8 into openshift:master May 2, 2024
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-operator-container-v4.16.0-202405021917.p0.g0120ab8.assembly.stream.el9 for distgit openshift-enterprise-console-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants