Merge pull request #4984 from andrewballantyne/triggers-start-modal

Triggers start modal

frontend/packages/dev-console/src/components/pipelines/PipelineDetailsPage.tsx

@@ -9,15 +9,13 @@ import { PipelineRunModel, PipelineModel } from '../../models';
 import { useMenuActionsWithUserLabel } from '../pipelineruns/triggered-by';
 import {
   PipelineDetails,
+  PipelineForm,
   PipelineParametersForm,
   PipelineResourcesForm,
   PipelineRuns,
-} from './detail-page-tabs';
-import PipelineForm from './pipeline-form/PipelineForm';
-import {
   parametersValidationSchema,
   resourcesValidationSchema,
-} from './pipeline-form/pipelineForm-validation-utils';
+} from './detail-page-tabs';
 
 const PipelineDetailsPage: React.FC<DetailsPageProps> = (props) => {
   const [errorCode, setErrorCode] = React.useState(null);

frontend/packages/dev-console/src/components/pipelines/const.ts

@@ -4,13 +4,20 @@ export enum StartedByLabel {
 }
 
 export enum PipelineResourceType {
-  '' = 'Select resource type',
-  git = 'Git',
-  image = 'Image',
-  cluster = 'Cluster',
-  storage = 'Storage',
+  git = 'git',
+  image = 'image',
+  cluster = 'cluster',
+  storage = 'storage',
 }
 
+export const pipelineResourceTypeSelections = {
+  '': 'Select resource type',
+  [PipelineResourceType.git]: 'Git',
+  [PipelineResourceType.image]: 'Image',
+  [PipelineResourceType.cluster]: 'Cluster',
+  [PipelineResourceType.storage]: 'Storage',
+};
+
 export enum VolumeTypes {
   EmptyDirectory = 'Empty Directory',
   ConfigMap = 'Config Map',

frontend/packages/dev-console/src/components/pipelines/detail-page-tabs/PipelineResources.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import { TextInputTypes } from '@patternfly/react-core';
 import { MultiColumnField, InputField, DropdownField } from '@console/shared';
-import { PipelineResourceType } from '../const';
+import { pipelineResourceTypeSelections } from '../const';
 
 type PipelineResourcesParam = {
   addLabel?: string;
@@ -27,7 +27,12 @@ const PipelineResources: React.FC<PipelineResourcesParam> = (props) => {
         placeholder="Name"
         isReadOnly={isReadOnly}
       />
-      <DropdownField name="type" items={PipelineResourceType} fullWidth disabled={isReadOnly} />
+      <DropdownField
+        name="type"
+        items={pipelineResourceTypeSelections}
+        fullWidth
+        disabled={isReadOnly}
+      />
     </MultiColumnField>
   );
 };

frontend/packages/dev-console/src/components/pipelines/detail-page-tabs/index.ts

@@ -4,3 +4,5 @@ export { default as PipelineParametersForm } from './PipelineParametersForm';
 export { default as PipelineResources } from './PipelineResources';
 export { default as PipelineResourcesForm } from './PipelineResourcesForm';
 export { default as PipelineRuns } from './PipelineRuns';
+export { default as PipelineForm } from './PipelineForm';
+export * from './pipelineForm-validation-utils';