New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triggers start modal #4984
Triggers start modal #4984
Conversation
e12a592
to
8423c7d
Compare
36aa0ec
to
315d091
Compare
0375b41
to
395e910
Compare
cc @siamaksade @serenamarie125 I had to change the way the Pipeline Resources worked... I tried for several hours today to try and make a reuse of existing structure, but we cannot be creating resources mid-modal and still use that logic for Triggers as the TriggerBinding params cannot be referenced from a fully-created and stand alone PipelineResource. It was too much duplicate not to impact the way the start modal was done as well. I prefer it this way tbh, resources shouldn't be created mid-modal - as if you cancel out, you shouldn't have extra resources. |
395e910
to
1c06dc0
Compare
e163ec9
to
5c1dbcc
Compare
5c1dbcc
to
2951e1b
Compare
2951e1b
to
9ee3124
Compare
9ee3124
to
ed9873a
Compare
...end/packages/dev-console/src/components/pipelines/modals/common/PipelineResourceDropdown.tsx
Outdated
Show resolved
Hide resolved
...tend/packages/dev-console/src/components/pipelines/modals/common/PipelineResourceSection.tsx
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines/modals/common/utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines/modals/common/utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines/modals/common/utils.ts
Outdated
Show resolved
Hide resolved
...d/packages/dev-console/src/components/pipelines/modals/start-pipeline/StartPipelineModal.tsx
Outdated
Show resolved
Hide resolved
64f16d3
to
4f7d41e
Compare
4f7d41e
to
993d3cd
Compare
frontend/packages/dev-console/src/components/pipelines/modals/common/ModalStructure.tsx
Outdated
Show resolved
Hide resolved
...end/packages/dev-console/src/components/pipelines/modals/common/PipelineParameterSection.tsx
Show resolved
Hide resolved
...end/packages/dev-console/src/components/pipelines/modals/common/PipelineResourceDropdown.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines/modals/triggers/AddTriggerForm.scss
Outdated
Show resolved
Hide resolved
...end/packages/dev-console/src/components/pipelines/modals/triggers/TriggerBindingSelector.tsx
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines/modals/triggers/submit-utils.ts
Outdated
Show resolved
Hide resolved
ecc49b0
to
481e8b5
Compare
481e8b5
to
bb2684e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
verified changes locally
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
/test e2e-gcp-console |
/hold |
/hold cancel |
Fixes:
https://issues.redhat.com/browse/ODC-3348
Analysis / Root cause:
Need a way to associate trigger resources with a Pipeline.
Solution Description:
Create a "Add Trigger" modal and under the hood bind everything together.
Main notes:
Screen shots / Gifs for design review:
@openshift/team-devconsole-ux
Add Trigger Modal:
Variables:
Use of variables mixed with static text:
Trigger Modal requests new resources to allow easy use of Parameters, but naturally not all resources need to be created fresh and thus can be referenced against existing resources:
TriggerTemplate
that was created at the finish of the modal:Unit test coverage report:
Test setup:
TriggerBindings
existBrowser conformance:
/kind feature