Skip to content

Commit

Permalink
Merge pull request #8103 from Jayashree-panda/baremetal
Browse files Browse the repository at this point in the history
Fixes inconsistent fonts on step 1 and step 2 of baremetal wizard
  • Loading branch information
openshift-merge-robot committed Feb 11, 2021
2 parents 1b8a7e2 + 129e561 commit 1860d41
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 13 deletions.
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Form } from '@patternfly/react-core';
import { Form, TextVariants } from '@patternfly/react-core';
import {
AutoDetectVolumeInner,
AutoDetectVolumeHeader,
Expand All @@ -11,7 +11,7 @@ import '../../attached-devices.scss';

export const AutoDetectVolume: React.FC<AutoDetectVolumeProps> = ({ state, dispatch }) => (
<>
<AutoDetectVolumeHeader />
<AutoDetectVolumeHeader className="ocs-install-wizard__h3" variant={TextVariants.h3} />
<Form noValidate={false} className="ceph-ocs-install__auto-detect-table">
<AutoDetectVolumeInner state={state} dispatch={dispatch} taintsFilter={hasOCSTaint} />
</Form>
Expand Down
@@ -1,6 +1,6 @@
import * as React from 'react';
import { useTranslation } from 'react-i18next';
import { Form, Alert, Button, Grid, GridItem } from '@patternfly/react-core';
import { Form, Alert, Button, Grid, GridItem, TextVariants } from '@patternfly/react-core';
import { Modal, useFlag } from '@console/shared';
import { k8sCreate } from '@console/internal/module/k8s';
import { LocalVolumeSetModel } from '@console/local-storage-operator-plugin/src/models';
Expand Down Expand Up @@ -64,7 +64,7 @@ export const CreateLocalVolumeSet: React.FC<CreateLocalVolumeSetProps> = ({

return (
<>
<LocalVolumeSetHeader />
<LocalVolumeSetHeader className="ocs-install-wizard__h3" variant={TextVariants.h3} />
<Grid className="ceph-ocs-install__form-wrapper">
<GridItem lg={10} md={12} sm={12}>
<Form noValidate={false}>
Expand Down
@@ -1,6 +1,6 @@
import * as React from 'react';
import { useTranslation } from 'react-i18next';
import { FormGroup, Radio } from '@patternfly/react-core';
import { FormGroup, Radio, Text, TextContent } from '@patternfly/react-core';
import { ListPage } from '@console/internal/components/factory';
import { NodeKind } from '@console/internal/module/k8s';
import { useK8sWatchResource } from '@console/internal/components/utils/k8s-watch-hook';
Expand Down Expand Up @@ -101,12 +101,19 @@ export const AutoDetectVolumeInner: React.FC<AutoDetectVolumeInnerProps> = ({
);
};

export const AutoDetectVolumeHeader = () => {
export const AutoDetectVolumeHeader: React.FC<AutoDetectVolumeHeaderProps> = ({
className,
variant,
}) => {
const { t } = useTranslation();

return (
<>
<h1 className="co-create-operand__header-text">{t('lso-plugin~Auto Detect Volume')}</h1>
<TextContent>
<Text component={variant} className={className}>
{t('lso-plugin~Auto Detect Volume')}
</Text>
</TextContent>
<p className="help-block">
{t('lso-plugin~Allows you to discover the available disks on all available nodes')}
</p>
Expand All @@ -119,3 +126,8 @@ type AutoDetectVolumeInnerProps = {
dispatch: React.Dispatch<Action>;
taintsFilter?: (node: NodeKind) => boolean;
};

type AutoDetectVolumeHeaderProps = {
variant: any;
className?: string;
};
@@ -1,6 +1,6 @@
import * as React from 'react';
import { match as RouterMatch } from 'react-router';
import { ActionGroup, Button, Form } from '@patternfly/react-core';
import { ActionGroup, Button, Form, TextVariants } from '@patternfly/react-core';
import {
resourcePathFromModel,
BreadCrumbs,
Expand Down Expand Up @@ -105,7 +105,7 @@ const AutoDetectVolume: React.FC = withHandlePromise<AutoDetectVolumeProps & Han
/>
</div>

<AutoDetectVolumeHeader />
<AutoDetectVolumeHeader variant={TextVariants.h1} />
</div>
<Form
noValidate={false}
Expand Down
@@ -1,7 +1,7 @@
import * as React from 'react';
import { useTranslation } from 'react-i18next';
import { match as RouterMatch } from 'react-router';
import { ActionGroup, Button, Form } from '@patternfly/react-core';
import { ActionGroup, Button, Form, TextVariants } from '@patternfly/react-core';
import {
resourcePathFromModel,
BreadCrumbs,
Expand Down Expand Up @@ -79,7 +79,7 @@ const CreateLocalVolumeSet: React.FC = withHandlePromise<
]}
/>
</div>
<LocalVolumeSetHeader />
<LocalVolumeSetHeader variant={TextVariants.h1} />
</div>
<Form
noValidate={false}
Expand Down
Expand Up @@ -7,6 +7,7 @@ import {
ExpandableSection,
TextInputTypes,
Text,
TextContent,
TextVariants,
Tooltip,
} from '@patternfly/react-core';
Expand Down Expand Up @@ -307,12 +308,19 @@ type LocalVolumeSetInnerProps = {
taintsFilter?: (node: NodeKind) => boolean;
};

export const LocalVolumeSetHeader = () => {
export const LocalVolumeSetHeader: React.FC<LocalVolumeSetHeaderProps> = ({
className,
variant,
}) => {
const { t } = useTranslation();

return (
<>
<h1 className="co-create-operand__header-text">{t('lso-plugin~Local Volume Set')}</h1>
<TextContent>
<Text component={variant} className={className}>
{t('lso-plugin~Local Volume Set')}
</Text>
</TextContent>
<p className="help-block">
{t(
'lso-plugin~A Local Volume Set allows you to filter a set of storage volumes group them and create a dedicated storage class to consume storage for them.',
Expand All @@ -321,3 +329,8 @@ export const LocalVolumeSetHeader = () => {
</>
);
};

type LocalVolumeSetHeaderProps = {
variant: any;
className?: string;
};

0 comments on commit 1860d41

Please sign in to comment.