Fixes inconsistent fonts on step 1 and step 2 of baremetal wizard #8103

Jayashree-panda · 2021-02-09T05:10:26Z

Signed-off-by: Jayashree-panda jayashreepanda12345@gmail.com
https://issues.redhat.com/browse/RHSTOR-1604

openshift-ci-robot · 2021-02-09T05:10:43Z

Hi @Jayashree-panda. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2021-02-09T05:18:08Z

...ges/local-storage-operator-plugin/src/components/local-volume-set/local-volume-set-inner.tsx

@@ -312,7 +313,11 @@ export const LocalVolumeSetHeader = () => {

  return (
    <>
-      <h1 className="co-create-operand__header-text">{t('lso-plugin~Local Volume Set')}</h1>
+      <TextContent>
+        <Text component={TextVariants.h3} className="ocs-install-wizard__h3">


We dont want to use ocs class in lso page. I would suggest to make it a prop.

Suggested change

<Text component={TextVariants.h3} className="ocs-install-wizard__h3">

<Text component={TextVariants.h3} className={className}>

Also, this will do the change in lso page form as well and for lso page, we still want to use h1, perhaps a prop component would be good to pass from ocs to this component.

This is a generic component, hence we must add props to it , rather than making a direct change. And keep the defaults.

@afreen23 I will make the changes. Thanks 👍

afreen23 · 2021-02-09T05:18:31Z

...local-storage-operator-plugin/src/components/auto-detect-volume/auto-detect-volume-inner.tsx

+        <Text component={TextVariants.h3} className="ocs-install-wizard__h3">
+          {t('lso-plugin~Auto Detect Volume')}
+        </Text>
+      </TextContent>


same as above.

Same as LocalVolumeHeader

afreen23 · 2021-02-10T03:55:41Z

...ges/local-storage-operator-plugin/src/components/local-volume-set/local-volume-set-inner.tsx

@@ -307,12 +308,16 @@ type LocalVolumeSetInnerProps = {
  taintsFilter?: (node: NodeKind) => boolean;
 };

-export const LocalVolumeSetHeader = () => {
+export const LocalVolumeSetHeader = ({ className, variant }) => {


Add types and make className optional

Suggested change

export const LocalVolumeSetHeader = ({ className, variant }) => {

export const LocalVolumeSetHeader: React.FC<LocalVolumeSetHeaderprops> = ({ className, variant }) => {

... type LocalVolumeSetHeader = { variant: string className?: string }

afreen23 · 2021-02-10T03:56:35Z

...es/local-storage-operator-plugin/src/components/local-volume-set/create-local-volume-set.tsx

@@ -79,7 +79,7 @@ const CreateLocalVolumeSet: React.FC = withHandlePromise<
            ]}
          />
        </div>
-        <LocalVolumeSetHeader />
+        <LocalVolumeSetHeader className={null} variant={TextVariants.h1} />


Make className optional prop

Suggested change

<LocalVolumeSetHeader className={null} variant={TextVariants.h1} />

<LocalVolumeSetHeader variant={TextVariants.h1} />

afreen23 · 2021-02-10T03:56:52Z

...kages/local-storage-operator-plugin/src/components/auto-detect-volume/auto-detect-volume.tsx

@@ -105,7 +105,7 @@ const AutoDetectVolume: React.FC = withHandlePromise<AutoDetectVolumeProps & Han
            />
          </div>

-          <AutoDetectVolumeHeader />
+          <AutoDetectVolumeHeader className={null} variant={TextVariants.h1} />


Make className optional

Suggested change

<AutoDetectVolumeHeader className={null} variant={TextVariants.h1} />

<AutoDetectVolumeHeader variant={TextVariants.h1} />

afreen23 · 2021-02-10T03:57:19Z

...local-storage-operator-plugin/src/components/auto-detect-volume/auto-detect-volume-inner.tsx

+        <Text component={TextVariants.h3} className="ocs-install-wizard__h3">
+          {t('lso-plugin~Auto Detect Volume')}
+        </Text>
+      </TextContent>


Same as LocalVolumeHeader

afreen23 · 2021-02-10T03:57:43Z

...c/components/ocs-install/attached-devices/create-sc/wizard-pages/create-local-volume-set.tsx

@@ -64,7 +64,7 @@ export const CreateLocalVolumeSet: React.FC<CreateLocalVolumeSetProps> = ({

  return (
    <>
-      <LocalVolumeSetHeader />
+      <LocalVolumeSetHeader className={'ocs-install-wizard__h3'} variant={TextVariants.h3} />


Suggested change

<LocalVolumeSetHeader className={'ocs-install-wizard__h3'} variant={TextVariants.h3} />

<LocalVolumeSetHeader className="ocs-install-wizard__h3"' variant={TextVariants.h3} />

afreen23 · 2021-02-10T03:58:00Z

...in/src/components/ocs-install/attached-devices/create-sc/wizard-pages/auto-detect-volume.tsx

@@ -11,7 +11,7 @@ import '../../attached-devices.scss';

 export const AutoDetectVolume: React.FC<AutoDetectVolumeProps> = ({ state, dispatch }) => (
  <>
-    <AutoDetectVolumeHeader />
+    <AutoDetectVolumeHeader className={'ocs-install-wizard__h3'} variant={TextVariants.h3} />


Suggested change

<AutoDetectVolumeHeader className={'ocs-install-wizard__h3'} variant={TextVariants.h3} />

<AutoDetectVolumeHeader className="ocs-install-wizard__h3" variant={TextVariants.h3} />

Signed-off-by: Jayashree-panda <jayashreepanda12345@gmail.com>

afreen23 · 2021-02-10T14:32:37Z

/ok-to-test

afreen23 · 2021-02-10T16:33:36Z

/test e2e-gcp-console
/lgtm

openshift-ci-robot · 2021-02-10T16:33:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, Jayashree-panda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [afreen23]
~~frontend/packages/local-storage-operator-plugin/OWNERS~~ [afreen23]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cloudbehl · 2021-02-11T04:20:03Z

/test e2e-gcp-console

openshift-ci-robot added the component/lso Related to local-storage-operator-plugin label Feb 9, 2021

openshift-ci-robot requested review from bipuladh and cloudbehl February 9, 2021 05:10

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 9, 2021

afreen23 suggested changes Feb 9, 2021

View reviewed changes

Jayashree-panda force-pushed the baremetal branch from 002a2f6 to f5e4177 Compare February 10, 2021 02:51

openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Feb 10, 2021

Jayashree-panda force-pushed the baremetal branch from f5e4177 to 23399d6 Compare February 10, 2021 03:07

afreen23 suggested changes Feb 10, 2021

View reviewed changes

fixes inconsistent fonts on step 1 and step 2 of baremetal wizard

129e561

Signed-off-by: Jayashree-panda <jayashreepanda12345@gmail.com>

Jayashree-panda force-pushed the baremetal branch from 23399d6 to 129e561 Compare February 10, 2021 05:12

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2021

openshift-ci-robot assigned afreen23 Feb 10, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2021

openshift-merge-robot merged commit 1860d41 into openshift:master Feb 11, 2021

spadgett added this to the v4.8 milestone Feb 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes inconsistent fonts on step 1 and step 2 of baremetal wizard #8103

Fixes inconsistent fonts on step 1 and step 2 of baremetal wizard #8103

Jayashree-panda commented Feb 9, 2021

openshift-ci-robot commented Feb 9, 2021

afreen23 Feb 9, 2021

afreen23 Feb 9, 2021 •

edited

Jayashree-panda Feb 9, 2021

afreen23 Feb 9, 2021 •

edited

afreen23 Feb 10, 2021

afreen23 Feb 10, 2021

afreen23 Feb 10, 2021

afreen23 Feb 10, 2021

afreen23 Feb 10, 2021

afreen23 Feb 10, 2021

afreen23 Feb 10, 2021

afreen23 commented Feb 10, 2021

afreen23 commented Feb 10, 2021

openshift-ci-robot commented Feb 10, 2021

cloudbehl commented Feb 11, 2021

	<Text component={TextVariants.h3} className="ocs-install-wizard__h3">
	<Text component={TextVariants.h3} className={className}>

	export const LocalVolumeSetHeader = ({ className, variant }) => {
	export const LocalVolumeSetHeader: React.FC<LocalVolumeSetHeaderprops> = ({ className, variant }) => {

	<LocalVolumeSetHeader className={null} variant={TextVariants.h1} />
	<LocalVolumeSetHeader variant={TextVariants.h1} />

	<AutoDetectVolumeHeader className={null} variant={TextVariants.h1} />
	<AutoDetectVolumeHeader variant={TextVariants.h1} />

	<LocalVolumeSetHeader className={'ocs-install-wizard__h3'} variant={TextVariants.h3} />
	<LocalVolumeSetHeader className="ocs-install-wizard__h3"' variant={TextVariants.h3} />

	<AutoDetectVolumeHeader className={'ocs-install-wizard__h3'} variant={TextVariants.h3} />
	<AutoDetectVolumeHeader className="ocs-install-wizard__h3" variant={TextVariants.h3} />

Fixes inconsistent fonts on step 1 and step 2 of baremetal wizard #8103

Fixes inconsistent fonts on step 1 and step 2 of baremetal wizard #8103

Conversation

Jayashree-panda commented Feb 9, 2021

openshift-ci-robot commented Feb 9, 2021

Choose a reason for hiding this comment

afreen23 Feb 9, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afreen23 Feb 9, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afreen23 commented Feb 10, 2021

afreen23 commented Feb 10, 2021

openshift-ci-robot commented Feb 10, 2021

cloudbehl commented Feb 11, 2021

afreen23 Feb 9, 2021 •

edited

afreen23 Feb 9, 2021 •

edited