Skip to content

Commit

Permalink
Merge pull request #9715 from andrewballantyne/fix-submit-errors-dev-…
Browse files Browse the repository at this point in the history
…only

Bug 1989707: Fixing Formik Promise.reject() issues by .resolve()-ing
  • Loading branch information
openshift-ci[bot] committed Aug 3, 2021
2 parents 8c7a7e6 + dccc1b3 commit a264bc9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const HPAFormikForm: React.FC<HPAFormikFormProps> = ({ existingHPA, targetResour
const invalidUsageError = getInvalidUsageError(hpa, values);
if (invalidUsageError) {
helpers.setStatus({ submitError: invalidUsageError });
return Promise.reject();
return Promise.resolve();
}

const method: (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,14 +162,14 @@ const HelmInstallUpgradePage: React.FunctionComponent<HelmInstallUpgradePageProp
errorsText: ajv.errorsText(),
}),
});
return Promise.reject();
return Promise.resolve();
}
} else if (yamlData) {
try {
valuesObj = safeLoad(yamlData);
} catch (err) {
actions.setStatus({ submitError: t('helm-plugin~Invalid YAML - {{err}}', { err }) });
return Promise.reject();
return Promise.resolve();
}
}

Expand Down

0 comments on commit a264bc9

Please sign in to comment.