Bug 1989707: Fixing Formik Promise.reject() issues by .resolve()-ing

[andrewballantyne]

Fixes:
https://issues.redhat.com/browse/ODC-6188

Analysis / Root cause:
Formik setSubmitting issues that were fixed in #8984 that assumed promise failures would not be a problem and would be handled by Formik. However, that was not the case and caused the local dev error window to appear.

Solution Description:
Promise.resolve instead of .reject in order to appease the Formik code. We handle errors on our end so it's not a means of echo'ing errors for us.

Test setup:

• Adding an HPA without metrics on a Deployment
• Modifying the Helm Releases yaml to an invalid state and submitting on the form page

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[andrewballantyne]

/cc @rohitkrai03

[rohitkrai03]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne,rohitkrai03]
• frontend/packages/helm-plugin/OWNERS [andrewballantyne,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@andrewballantyne: This pull request references Bugzilla bug 1989707, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1989707: Fixing Formik Promise.reject() issues by .resolve()-ing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/retest

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@andrewballantyne: All pull requests linked via external trackers have merged:

• openshift/console#9715

Bugzilla bug 1989707 has been moved to the MODIFIED state.

In response to this:

Bug 1989707: Fixing Formik Promise.reject() issues by .resolve()-ing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.