Merge pull request #2997 from sg00dwin/metrics-time-select-bug

Center the placement of dropdown toggle-icon on the metrics time selection
openshift · Oct 18, 2019 · b02795a · b02795a
2 parents 5afcf96 + 3364b62
commit b02795a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/frontend/public/components/_dropdown.scss b/frontend/public/components/_dropdown.scss
@@ -22,6 +22,15 @@ $dropdown-background--hover: $color-pf-black-200; // pf-c-dropdown__menu-item--h
   }
 }
 
+.dropdown-button--icon-only {
+  height: 34.5px !important; // default form element height
+  margin-left: -1px;
+  min-width: auto !important;
+  .pf-c-dropdown__toggle-icon {
+    margin: 0 !important;
+  }
+}
+
 .dropdown__disabled {
   color: $dropdown-link-disabled-color;
   cursor: not-allowed;

diff --git a/frontend/public/components/monitoring/_monitoring.scss b/frontend/public/components/monitoring/_monitoring.scss
@@ -120,11 +120,6 @@
   }
 }
 
-.query-browser__span-dropdown-button {
-  margin-left: -1px;
-  width: 44px;
-}
-
 .query-browser__span-dropdown-menu {
   right: 0;
   width: 130px;

diff --git a/frontend/public/components/monitoring/query-browser.tsx b/frontend/public/components/monitoring/query-browser.tsx
@@ -110,12 +110,11 @@ const SpanControls: React.FC<SpanControlsProps> = React.memo(
           value={text}
         />
         <Dropdown
-          buttonClassName="query-browser__span-dropdown-button"
+          buttonClassName="dropdown-button--icon-only"
           items={dropdownItems}
           menuClassName="query-browser__span-dropdown-menu"
           noSelection={true}
           onChange={(v) => setSpan(v)}
-          title="&nbsp;"
         />
         <Button
           className="query-browser__inline-control"