Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center the placement of dropdown toggle-icon on the metrics time selection #2997

Merged
merged 1 commit into from Oct 18, 2019
Merged

Center the placement of dropdown toggle-icon on the metrics time selection #2997

merged 1 commit into from Oct 18, 2019

Conversation

sg00dwin
Copy link
Member

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality labels Oct 16, 2019
rhamilto
rhamilto reviewed Oct 16, 2019
View reviewed changes
frontend/public/style/_overrides.scss Outdated
@@ -148,6 +148,10 @@ h6 {
color: var(--pf-c-button--m-plain--Color);
}

.pf-c-dropdown__toggle.query-browser__span-dropdown-button .pf-c-dropdown__toggle-icon {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This selector is incredibly specific, so we'll have this same bug any time a similar component combo is used.

This seems like an upstream bug, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I don't think so, I think the larger issue is we're using a PF4 <TextInput> along with our custom <Dropdown> that has no text (the default margin is to separate that text from pf-c-dropdown__toggle-icon). It seems this should be a PF4 <Select>

I could make it reduce specificity some and !important to give priority?

.query-browser__span-dropdown-button .pf-c-dropdown__toggle-icon {
  margin-left: 6px !important;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see that wouldn't work, since the reason they are using a <TextInput> is so custom values can be used

@openshift-ci-robot openshift-ci-robot added component/monitoring Related to monitoring size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2019
rhamilto
rhamilto reviewed Oct 17, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/retest

@spadgett spadgett added this to the v4.3 milestone Oct 18, 2019
@spadgett
Copy link
Member

/refresh

@openshift-merge-robot openshift-merge-robot merged commit b02795a into openshift:master Oct 18, 2019
@sg00dwin sg00dwin deleted the metrics-time-select-bug branch October 21, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sg00dwin @openshift-ci-robot @openshift-bot @spadgett @rhamilto @openshift-merge-robot