Bug 2002387: updating user settings storage to local in cypress hooks for dev-console plugin

[makambalaji]

Description:
Currently modifications made by user are getting stored in user settings config map. So setting up the user settings storage to "local storage" instead user settings config map

Updating project dropdown locators

[openshift-ci]

@makambalaji: This pull request references Bugzilla bug 2002387, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2002387: update cypress hooks for modifying user settings storage to local

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/integration-tests/OWNERS [makambalaji]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@makambalaji: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 2002387 : updating user settings storage to local in cypress hooks for dev-console plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@makambalaji: This pull request references Bugzilla bug 2002387, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2002387: updating user settings storage to local in cypress hooks for dev-console plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@makambalaji: This pull request references Bugzilla bug 2002387, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2002387: updating user settings storage to local in cypress hooks for dev-console plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[makambalaji]

/bugzilla refresh

[openshift-ci]

@makambalaji: This pull request references Bugzilla bug 2002387, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[makambalaji]

/bugzilla refresh

[openshift-ci]

@makambalaji: This pull request references Bugzilla bug 2002387, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/hold

I'm nervous about not having test coverage of the user settings config map, particularly since we generally run with localStorage during development. Is this issue that tests can break when run against a shared cluster, or do we just want to reset user settings between tests?

[makambalaji]

/hold

I'm nervous about not having test coverage of the user settings config map, particularly since we generally run with localStorage during development. Is this issue that tests can break when run against a shared cluster, or do we just want to reset user settings between tests?

@spadgett - Test cases are already designed for user settings related feature, In CI - Due to this feature[previous user settings are saved], Tests are getting flaky. To avoid this, setting user settings to "local storage". So that there won't be any issue.
At the same time, they are part of Regression testing, so we will execute this scripts n every release

[spadgett]

We need to be testing user settings saved in config map in CI. If previous settings are causing problem, it would be better to delete the config map between tests.

[christianvogt]

Overall if a test isn't reproducible due to preserved state then the test itself isn't correctly written to do a proper setup and /or tear down. A test should be capable of running no matter what current system state.

[makambalaji]

We need to be testing user settings saved in config map in CI. If previous settings are causing problem, it would be better to delete the config map between tests.

We can delete it, but this increases the execution time on CI. If still needs to proceed, yes we can delete config maps

[spadgett]

We can delete it, but this increases the execution time on CI. If still needs to proceed, yes we can delete config maps

It can be an oc delete command. The difference should be negligible. I think it's simplest to just delete the kubeadmin settings config map before each test scenario (similar to how Cypress deletes cookies between tests by default). Then you never have to worry about test order and makes writing the tests easier.

[jerolimov]

@makambalaji do you want update this PR/bug to delete the complete ConfigMap or should we check if the tests tear down correctly?

Scenarios which could make issues:

• Tests which changes the new user preferences => They should just set the settings to the default value at the end.
• Tests which switch the topology view to list => They should just switch to graph view at the end.
• Others?

Do we have other hacks (for example for the perspective switch clicks many times if I'm correct) which could benefit if we have always a clear state? Could we remove "magic code" if we add a oc delete? :D

[makambalaji]

@makambalaji do you want update this PR/bug to delete the complete ConfigMap or should we check if the tests tear down correctly?

Scenarios which could make issues:

• Tests which changes the new user preferences => They should just set the settings to the default value at the end.
• Tests which switch the topology view to list => They should just switch to graph view at the end.
• Others?

Do we have other hacks (for example for the perspective switch clicks many times if I'm correct) which could benefit if we have always a clear state? Could we remove "magic code" if we add a oc delete? :D

Closing this pr and will create a new pr with different bug id

[openshift-ci]

@makambalaji: This pull request references Bugzilla bug 2002387. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 2002387: updating user settings storage to local in cypress hooks for dev-console plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.