Gherkin:Manage user preferences

[sanketpathak]

Epic: https://issues.redhat.com/browse/ODC-5227
Story: https://issues.redhat.com/browse/ODC-5970

Acceptance criteria:

• Users have the ability to set their user preferences

Checks required for approving Epic gherkin scripts PR:

• Add @epic-number to the scenarios or feature file [e.g: @odc-xxx]
• Add @to-do for automation possible scenarios
• Add @regression or @smoke based on the importance of the scenario
• Update the test scenarios count in Automation status confluence Report
• Check for the linter issues by executing yarn run gherkin-lint on frontend folder [Skip epic number tags related linter issues]

[makambalaji]

I think we can remove this scenario. In below scenario,
'And user clicks User Preference option' - covers this scenario

[makambalaji]

IMO, we can remove this steps, because user settings are available on MastHead. WDYT?

[nemesis09]

I agree. The user preferences page can be accessed from both admin and dev console, without creating a namespace

[makambalaji]

Suggested change

	When user clicks on user dropdown
	When user clicks "kubeadmin" dropdown on masthead

[nemesis09]

The user can be a non admin user as well, so "kubeadmin" would not be an accurate description IMO.

[sanketpathak]

It will apply for non-admin users as well

[makambalaji]

Suggested change

	And user clicks on Add from navigation menu
	And user clicks on Add present in navigation menu

[nemesis09]

Clicking on Add from navigation menu will not reflect any change since the link associated with this menu option uses the active namespace.
To notice a change after setting the preference for a Project, the user would have to load the console without any url params for namespace.
cc @jerolimov

[jerolimov]

It is true that the user needs to reload the console to get the selected perspective. But I think the selected project should be also visible if the user switches from the admin perspective to the developer perspective, or?

[sanketpathak]

Updated

[makambalaji]

same as above

[nemesis09]

As per my understanding of the epic, This should be true if the active project when the user was initially on the Add page, was ALL_PROJECTS.
but generally, setting a preference for namespace means, this preference will be honored when the console loads without any url params. in other cases, if an active project is detected, it will have preference over the preferred project.
cc @jerolimov

[jerolimov]

This is outdated. But yep, when the user switches to the add page she or he should see the right namespace. But the console saves the latest namespace internally, so maybe a page reload is required. (window.location.href = '/add')

[sanketpathak]

Updated

[nemesis09]

I agree. The user preferences page can be accessed from both admin and dev console, without creating a namespace

[nemesis09]

The user can be a non admin user as well, so "kubeadmin" would not be an accurate description IMO.

[nemesis09]

to see a change after selecting "Developer" option in the dropdown, the user needs to load console, usually by clicking the Brand/Logo
We should add that step.

[sanketpathak]

Should given condition have user in the admin view and will the change occur then as well i.e. clicking on Brand/Logo will take user to developer perspective

[jerolimov]

I discussed this with Christian and at the moment we don't want change the user perspective when the logo is pressed.

What the user should do to go to the selected perspective is to reload the current page. I would describe it like this:

Suggested change

	Then user can see "Developer" option selected in the perspective switcher
	And user reloads the console without perspective.
	Then user sees the "Developer" perspective

I changed the second sentence as well. It is not important if the perspective switches contains the option Developer (this should be always the case). I expect that you want say that the dropdown current option is Developer. You can check this this way. But for the user it is important that she or he is on the developer perspective.

[sanketpathak]

Updated

[nemesis09]

Clicking on Add from navigation menu will not reflect any change since the link associated with this menu option uses the active namespace.
To notice a change after setting the preference for a Project, the user would have to load the console without any url params for namespace.
cc @jerolimov

[nemesis09]

As per my understanding of the epic, This should be true if the active project when the user was initially on the Add page, was ALL_PROJECTS.
but generally, setting a preference for namespace means, this preference will be honored when the console loads without any url params. in other cases, if an active project is detected, it will have preference over the preferred project.
cc @jerolimov

[nemesis09]

This is true as per the current understanding of the UX. However it may change later when the PR for the related story goes into review. We should go ahead with this now, since this is true as per the UXD and acceptance criteria.

[sanketpathak]

In case of change you can update the gherkin as well with your pr

[jerolimov]

I would recommend to have one action here so that you can select the item within this dropdown. I believe this makes it easier to implement the action later, and imho it describes more what the user is doing:

Suggested change

	When user clicks on user dropdown on masthead
	And user clicks User Preference option
	When user clicks on user dropdown and selects "User Preference"

[sanketpathak]

Updated

[jerolimov]

Same here, I believe its easier to implement this gherkin sentences later if the dropdown and selected value/option are in one action:

Suggested change

	And user clicks on Perspective dropdown on User Preferences page
	And user selects "Developer" option
	And user changes user preference "Perspective" dropdown to "Developer"

[sanketpathak]

Updated

[jerolimov]

I discussed this with Christian and at the moment we don't want change the user perspective when the logo is pressed.

What the user should do to go to the selected perspective is to reload the current page. I would describe it like this:

Suggested change

	Then user can see "Developer" option selected in the perspective switcher
	And user reloads the console without perspective.
	Then user sees the "Developer" perspective

I changed the second sentence as well. It is not important if the perspective switches contains the option Developer (this should be always the case). I expect that you want say that the dropdown current option is Developer. You can check this this way. But for the user it is important that she or he is on the developer perspective.

[jerolimov]

Suggested change

	Given user has created project "test-preference1"
	Given user has created project "test-preference2"

[sanketpathak]

That is not required, I'll remove it

[jerolimov]

@sanketpathak I added some comments to reduce the number of gherkin variants. Please check also the user cases which contains similar sentences.

When checking the perspective we should redirect the user to the root page with something like window.location.href = '/'. /cc @nemesis09

[jerolimov]

I miss here the additional test that, if the user opens the console that the selected project is preselected.

Suggested change

	Then user can see "test-preference1" option selected in project namespace
	Then user can see "test-preference1" option selected in project namespace
	And user switches to the add page the project "test-preference1" is preselected.

[sanketpathak]

Updated

[jerolimov]

Here as well:

Suggested change

	Then user can see "test-preference2" option selected in project namespace
	Then user can see "test-preference2" option selected in project namespace
	And user switches to the add page the project "test-preference2" is preselected.

Btw, what is the difference between UP-01-TC02 and UP-01-TC03?

[sanketpathak]

UP-01-TC02 scenario is that the user has already created a namespace and through user preferences, that particular namespace gets selected, on the other hand, the UP-01-TC03 scenario says that the namespace is created by the user on the user preferences page and that namespace gets selected by it.

[jerolimov]

Typo

Suggested change

	When usewr selects "All projets" from the project menu
	When user selects "All projets" from the project menu

[sanketpathak]

Updated

[jerolimov]

Small feedback

[jerolimov]

I expect you mean "...in project dropdown" instead of "...in project namespace". But you can make it more clear with a sentence like this. Its up to you, but at least change to project dropdown or something similar.

Suggested change

	Then user can see "test-preference1" option selected in project namespace
	Then user can see that project "test-preference1" is selected

[sanketpathak]

Updated

[jerolimov]

I expect you mean "...in project dropdown" instead of "...in project namespace". But you can make it more clear with a sentence like this. Its up to you, but at least change to project dropdown or something similar.

Suggested change

	And user can see "test-preference2" option selected in project namespace
	And user can see that project "test-preference2" is selected

[sanketpathak]

This(user can see) can not be part of the when statement so removed it

[jerolimov]

I expect you mean "...in project dropdown" instead of "...in project namespace". But you can make it more clear with a sentence like this. Its up to you, but at least change to project dropdown or something similar.

Suggested change

	And user can see "test-preference2" option selected in project namespace
	And user can see that project "test-preference2" is selected

[sanketpathak]

Updated on similar lines

[jerolimov]

Should be the same action as above.

Suggested change

	And user selects "Form" option on Create/Edit resource method dropdown on User Preferences page
	And user changes user preference "Create/Edit resource method" dropdown to "Form"

[sanketpathak]

Updated

[jerolimov]

Should be the same action as above.

Suggested change

	And user selects "YAML" option on Create/Edit resource method dropdown on User Preferences page
	And user changes user preference "Create/Edit resource method" dropdown to "YAML"

[sanketpathak]

Updated

[jerolimov]

Thanks @sanketpathak for being open for also this small suggestions. 👍

/lgtm

[jerolimov]

Unapprove it just to get @makambalaji approval! For me this is fine. :)

/approve cancel

[jerolimov]

/assign @makambalaji

[makambalaji]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/integration-tests/OWNERS [makambalaji]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerolimov]

PR addresses integration test configuration only and all tests are @todo

/label px-approved
/label docs-approved
/label qe-approved