-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2002397: Avoid using state for search page resources filter #10023
Bug 2002397: Avoid using state for search page resources filter #10023
Conversation
@rottencandy: This pull request references Bugzilla bug 2002397, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @invincibleJai |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, rottencandy, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@rottencandy: All pull requests linked via external trackers have merged: Bugzilla bug 2002397 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-6334
https://bugzilla.redhat.com/show_bug.cgi?id=2002397
Analysis / Root cause:
The resource dropdown was using
useState
and the state's value in the same render, causing the filter to be behind one character.Solution Description:
Remove the state, and directly use the input event value.
Screen shots / Gifs for design review:
0.mp4
Unit test coverage report:
(Unchanged)
Browser conformance:
/kind bug