Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1999619: #cloud-config is now added to yaml #10057

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Bug 1999619: #cloud-config is now added to yaml #10057

merged 1 commit into from
Sep 15, 2021

Conversation

metalice
Copy link
Contributor

Signed-off-by: Matan Schatzman mschatzm@redhat.com

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1999619

Analysis / Root cause:
Missing header #cloud-config

Solution Description:
Added missing header #cloud-config

Screen shots / Gifs for design review:
After:
image

Before:
image

@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

@metalice: This pull request references Bugzilla bug 1999619, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1999619: #cloud-config is now added to yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 13, 2021
@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Sep 13, 2021
@yaacov
Copy link
Member

yaacov commented Sep 13, 2021

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 13, 2021
pcbailey
pcbailey reviewed Sep 13, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/volume-wrapper.ts Outdated
@@ -131,6 +132,11 @@ export class VolumeWrapper extends ObjectWithTypePropertyWrapper<
return this;
};

setCloudIntNoCloud = (value: V1CloudInitNoCloudSource) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo: setCloudIntNoCloud => setCloudInitNoCloud

@metalice
Bug 1999619: #cloud-config is now added to yaml
8d085f4 
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice metalice force-pushed the bz-1999619-adding-cloudinit-config-line-as-string branch from f098467 to 8d085f4 Compare September 13, 2021 12:55
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

@openshift-bot: This pull request references Bugzilla bug 1999619, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Sep 14, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

@yaacov: This pull request references Bugzilla bug 1999619, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang September 14, 2021 07:45
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 096e16e into openshift:master Sep 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 1999619 has been moved to the MODIFIED state.

In response to this:

Bug 1999619: #cloud-config is now added to yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
@yaacov
Copy link
Member

yaacov commented Nov 15, 2021

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link

@yaacov: #10057 failed to apply on top of branch "release-4.8":

Applying: Bug 1999619: #cloud-config is now added to yaml
Using index info to reconstruct a base tree...
M	frontend/packages/kubevirt-plugin/src/k8s/requests/vm/create/initialize-vm.ts
M	frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/volume-wrapper.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/volume-wrapper.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/volume-wrapper.ts
Auto-merging frontend/packages/kubevirt-plugin/src/k8s/requests/vm/create/initialize-vm.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1999619: #cloud-config is now added to yaml
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Nov 15, 2021

/cherry-pick release-4.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 15, 2021
Merged
@openshift-cherrypick-robot
Copy link

@yaacov: new pull request created: #10459

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey pcbailey left review comments

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@yaacov yaacov

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
7 participants
@metalice @yaacov @pcbailey @openshift-bot @openshift-cherrypick-robot @spadgett @openshift-merge-robot