Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2004796: add test for vm scheduling policy #10081

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Bug 2004796: add test for vm scheduling policy #10081

merged 1 commit into from
Sep 20, 2021

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Sep 16, 2021

No description provided.

@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Sep 16, 2021
@gouyang gouyang changed the title add test for vm scheduling policy Bug 2004796: add test for vm scheduling policy Sep 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@gouyang: This pull request references Bugzilla bug 2004796, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2004796: add test for vm scheduling policy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 2004796, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2004796: add test for vm scheduling policy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gouyang
Copy link
Contributor Author

gouyang commented Sep 16, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@gouyang gouyang force-pushed the vm_scheduling branch 2 times, most recently from d6c390e to 4d1a36c Compare September 16, 2021 11:30
pcbailey
pcbailey reviewed Sep 16, 2021
View reviewed changes
...end/packages/kubevirt-plugin/integration-tests-cypress/tests/tabs/details-scheduling.spec.ts Outdated
});
});

it('ID(CNV-4489) VM is scheduled on labelled node', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: "labelled" => "labeled"

...end/packages/kubevirt-plugin/integration-tests-cypress/tests/tabs/details-scheduling.spec.ts Outdated
cy.get(nodeSelector).should('contain', noSelector);
});

it('ID(CNV-4491) VM can be scheduling to tainted node with matched tolerations', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: "scheduling" => "scheduled" and "matched" => "matching"

...end/packages/kubevirt-plugin/integration-tests-cypress/tests/tabs/details-scheduling.spec.ts Outdated
});

it('ID(CNV-4491) VM can be scheduling to tainted node with matched tolerations', () => {
// make it downstream only as taint node may cause flakes, hard to debug in upstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: "taint" => "tainted" and "hard to..." => "which is hard to..."

...end/packages/kubevirt-plugin/integration-tests-cypress/tests/tabs/details-scheduling.spec.ts Outdated
}
});

it('ID(CNV-4159) VM can be scheduling to node with affinity rules', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: "scheduling" => "scheduled"

frontend/packages/kubevirt-plugin/integration-tests-cypress/utils/const/string.ts Outdated
export const BOOTSOURCE_ERROR =
'This disk does not have a source defined and can not be used as a boot source';

// ui strings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: "ui" => "UI"

@gouyang gouyang force-pushed the vm_scheduling branch 2 times, most recently from 4d19bec to 0cf0eac Compare September 16, 2021 12:10
@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 16, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@gouyang
Copy link
Contributor Author

gouyang commented Sep 17, 2021

/retest

@gouyang gouyang force-pushed the vm_scheduling branch 2 times, most recently from 22fc2ff to 939ea6f Compare September 17, 2021 12:21
@gouyang
Copy link
Contributor Author

gouyang commented Sep 20, 2021

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ecb08cf into openshift:master Sep 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

@gouyang: All pull requests linked via external trackers have merged:

Bugzilla bug 2004796 has been moved to the MODIFIED state.

In response to this:

Bug 2004796: add test for vm scheduling policy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey pcbailey left review comments

@mareklibra mareklibra Awaiting requested review from mareklibra

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
4 participants
@gouyang @pcbailey @spadgett @openshift-merge-robot