Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.8] Bug 2005917: CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False #10103

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Sep 20, 2021

Backport of #9329

/assign @spadgett

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

@jhadvig: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2021
@jhadvig jhadvig changed the title [release-4.8] CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False [release-4.8] Bug 2005493: CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False Sep 20, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

@jhadvig: This pull request references Bugzilla bug 2005493, which is invalid:

  • expected the bug to target the "4.8.z" release, but it targets "---" instead
  • expected Bugzilla bug 2005493 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 2005493: CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Member Author

jhadvig commented Sep 20, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

@jhadvig: This pull request references Bugzilla bug 2005493, which is invalid:

  • expected Bugzilla bug 2005493 to depend on a bug targeting a release in 4.9.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig jhadvig changed the title [release-4.8] Bug 2005493: CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False [release-4.8] Bug 2005917: CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False Sep 20, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Sep 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

@jhadvig: This pull request references Bugzilla bug 2005917, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2005493 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2005493 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

[release-4.8] Bug 2005917: CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 20, 2021
@openshift-ci openshift-ci bot requested a review from yapei September 20, 2021 13:44
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Clean cherry-pick of 4.9 fix.

@spadgett
Copy link
Member

@sdodson @rhamilto FYI

@sdodson
Copy link
Member

sdodson commented Sep 20, 2021

Patch manager, this is a feature backport which significantly improves the user experience around the admin acknowledgements which we intend to land in 4.8.z as a prerequisite to upgrading to 4.9. This makes Upgradeable=False conditions visible on the upgrade page so that the admin knows what they need to go resolve prior to attempting a minor version upgrade.

If you have any concerns about approving this please reach out to me.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member Author

jhadvig commented Sep 21, 2021

@openshift/openshift-patch-managers ˆˆ

@hardys
Copy link

hardys commented Sep 21, 2021

[patch-manager] Approving for cherry-pick with a score of 0.20 - medium prio bz but comments mention significant Ux improvement

@hardys hardys added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9d10d04 into openshift:release-4.8 Sep 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

@jhadvig: All pull requests linked via external trackers have merged:

Bugzilla bug 2005917 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 2005917: CONSOLE-2152: Improve upgrade messaging when ClusterVersion Upgradeable=False

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants