Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2003120: Prevent null references and "ResizeObserver loop limit exceeded" errors in IFrameMarkdownView #10114

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Bug 2003120: Prevent null references and "ResizeObserver loop limit exceeded" errors in IFrameMarkdownView #10114

merged 1 commit into from
Sep 21, 2021

Conversation

TheRealJon
Copy link
Member

  • Fix optional chaining in frontend/public/components/markdown-view.tsx and frontend/public/components/app.jsx to prevent null/undefined references
  • Wrap IFrameMarkdownView updateDimensions function in _.debounce to prevent ResizeObserver loop limit exceeded
  • Update logic in IFrameMarkdownView updateDimensions to use React state rather than directly modifying the style property of the iframe element.

@TheRealJon
Fix 2003120: Prevent null references and "ResizeObserver loop limit e…
173b6b4 
…xceeded" errors in IFrameMarkdownView

- Fix optional chaining in frontend/public/components/markdown-view.tsx and frontend/public/components/app.jsx to prevent null/undefined references
- Wrap IFrameMarkdownView updateDimensions function in _.debounce to prevent ResizeObserver loop limit exceeded
- Update logic in IFrameMarkdownView updateDimensions to use React state rather than directly modifying the style property of the iframe element
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Sep 21, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021
@TheRealJon TheRealJon changed the title Fix 2003120: Prevent null references and "ResizeObserver loop limit exceeded" errors in IFrameMarkdownView Bug 2003120: Prevent null references and "ResizeObserver loop limit exceeded" errors in IFrameMarkdownView Sep 21, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

@TheRealJon: This pull request references Bugzilla bug 2003120, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2003120: Prevent null references and "ResizeObserver loop limit exceeded" errors in IFrameMarkdownView

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei September 21, 2021 16:06
spadgett
spadgett approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

/cherry-pick release-4.9

@openshift-cherrypick-robot
Copy link

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a9f1668 into openshift:master Sep 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

@TheRealJon: All pull requests linked via external trackers have merged:

Bugzilla bug 2003120 has been moved to the MODIFIED state.

In response to this:

Bug 2003120: Prevent null references and "ResizeObserver loop limit exceeded" errors in IFrameMarkdownView

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@spadgett: new pull request created: #10116

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 21, 2021
Merged
@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
@TheRealJon TheRealJon deleted the 2003120 branch January 27, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@zherman0 zherman0 Awaiting requested review from zherman0

@yapei yapei Awaiting requested review from yapei

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
4 participants
@TheRealJon @spadgett @openshift-cherrypick-robot @openshift-merge-robot