Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2019360: Create the Virtualization Overview page #10233

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Bug 2019360: Create the Virtualization Overview page #10233

merged 1 commit into from
Nov 12, 2021

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Oct 13, 2021 •
edited
Loading

This is the start of the Virtualization Overview page feature. This PR creates the Getting Started card and the side navigation tab.

Full page screenshot:
Selection_019

Card-only screenshot:
Selection_018

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console labels Oct 13, 2021
@openshift-ci openshift-ci bot added component/helm Related to helm-plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 13, 2021
@pcbailey pcbailey force-pushed the virt-overview-getting-started-card branch 2 times, most recently from 9fc2156 to 5b4facc Compare October 14, 2021 01:24
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2021
@pcbailey pcbailey force-pushed the virt-overview-getting-started-card branch from 5b4facc to cf07ed5 Compare October 20, 2021 12:54
glekner
glekner suggested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@glekner glekner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @pcbailey

...plugin/src/components/virtualization-overview/getting-started-card/FeatureHighlightsCard.tsx Outdated Show resolved Hide resolved
...gin/src/components/virtualization-overview/getting-started-card/RecommendedOperatorsCard.tsx Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/image-files/operators_icon.svg Outdated Show resolved Hide resolved
...gin/src/components/virtualization-overview/getting-started-card/RecommendedOperatorsCard.tsx Outdated Show resolved Hide resolved
...tend/packages/console-shared/src/components/getting-started/QuickStartGettingStartedCard.tsx Show resolved Hide resolved
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2021
@pcbailey pcbailey force-pushed the virt-overview-getting-started-card branch from cf07ed5 to 30a190c Compare October 20, 2021 18:54
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2021
@pcbailey pcbailey force-pushed the virt-overview-getting-started-card branch 2 times, most recently from 75b3d8a to 4963964 Compare October 21, 2021 18:19
@pcbailey pcbailey changed the title WIP: Create the Virtualization Overview page Create the Virtualization Overview page Oct 23, 2021
@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 2, 2021

/retest

2 similar comments
@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 3, 2021

/retest

@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 7, 2021

/retest

@pcbailey pcbailey force-pushed the virt-overview-getting-started-card branch from 1228df1 to 72d834b Compare November 9, 2021 15:09
@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 9, 2021

/retest

4 similar comments
@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 9, 2021

/retest

@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 9, 2021

/retest

@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 9, 2021

/retest

@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 9, 2021

/retest

@pcbailey pcbailey force-pushed the virt-overview-getting-started-card branch from 72d834b to 8209df0 Compare November 10, 2021 01:53
@pcbailey
Copy link
Contributor Author

/retest

3 similar comments
@pcbailey
Copy link
Contributor Author

/retest

@pcbailey
Copy link
Contributor Author

/retest

@pcbailey
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021 •
edited
Loading

@pcbailey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ceph-storage-plugin 9fc2156 link true /test ceph-storage-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pcbailey
Copy link
Contributor Author

/retest

@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit a468204 into openshift:master Nov 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2021

@pcbailey: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2019360 has not been moved to the MODIFIED state.

In response to this:

Bug 2019360: Create the Virtualization Overview page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 19, 2021
Merged
Merged
Merged
@spadgett spadgett added this to the v4.10 milestone Dec 8, 2021
@openshift-ci openshift-ci bot mentioned this pull request Dec 21, 2021
Merged
@pcbailey pcbailey deleted the virt-overview-getting-started-card branch October 26, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glekner glekner glekner requested changes

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@andybraren andybraren Awaiting requested review from andybraren

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@vojtechszocs vojtechszocs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
5 participants
@pcbailey @vojtechszocs @glekner @spadgett @openshift-merge-robot