Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 2005871: Cannot create Network Attachment Definition through UI #10314

Merged
merged 1 commit into from Nov 1, 2021
Merged

[release-4.8] Bug 2005871: Cannot create Network Attachment Definition through UI #10314

merged 1 commit into from Nov 1, 2021

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Oct 25, 2021

Signed-off-by: Aviv Turgeman aturgema@redhat.com

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2021

@avivtur: This pull request references Bugzilla bug 2005871, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1987169 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1987169 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2005871: Cannot create Network Attachment Definition through UI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/network-attachment-definition Related to network-attachment-definition label Oct 25, 2021
@yaacov
Copy link
Member

yaacov commented Oct 25, 2021

/lgtm

@yaacov
Copy link
Member

yaacov commented Oct 25, 2021

manual backport of: #9688

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
yaacov
yaacov reviewed Oct 25, 2021
View reviewed changes
...on-plugin/src/components/network-attachment-definitions/NetworkAttachmentDefinitionsForm.tsx Outdated
import { useTranslation } from 'react-i18next';
import { connect } from 'react-redux';
import { Link } from 'react-router-dom';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no empty lines allowed ...

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@pcbailey
Copy link
Contributor

/lgtm

@avivtur
Bug 2005871: Cannot create Network Attachment Definition through UI
f67f015 
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@yaacov yaacov removed their assignment Oct 29, 2021
@yaacov
Copy link
Member

yaacov commented Oct 29, 2021

Manual backport of: #9688

/retitle [release-4.8] Bug 2005871: Cannot create Network Attachment Definition through UI
/assign @pcbailey

@openshift-ci openshift-ci bot changed the title Bug 2005871: Cannot create Network Attachment Definition through UI [release-4.8] Bug 2005871: Cannot create Network Attachment Definition through UI Oct 29, 2021
@pcbailey
Copy link
Contributor

pcbailey commented Nov 1, 2021

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

@pcbailey: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Nov 1, 2021

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 1, 2021
@stleerh stleerh added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 1, 2021
@yaacov
Copy link
Member

yaacov commented Nov 1, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit af77da0 into openshift:release-4.8 Nov 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2005871 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 2005871: Cannot create Network Attachment Definition through UI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov left review comments

@gouyang gouyang Awaiting requested review from gouyang

@pcbailey pcbailey Awaiting requested review from pcbailey

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/network-attachment-definition Related to network-attachment-definition lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@avivtur @yaacov @pcbailey @openshift-bot @openshift-merge-robot @stleerh