Bug 2019986: Fix dynamic demo plugin build #10395

vojtechszocs · 2021-11-03T18:17:29Z

This PR adapts Console dynamic demo plugin to changes made in #10383

spadgett

/lgtm

openshift-ci · 2021-11-03T18:57:53Z

@vojtechszocs: This pull request references Bugzilla bug 2019986, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2019986: Fix dynamic demo plugin build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vojtechszocs · 2021-11-03T18:58:28Z

/bugzilla refresh

openshift-ci · 2021-11-03T19:00:33Z

@vojtechszocs: This pull request references Bugzilla bug 2019986, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rawagner · 2021-11-03T19:18:10Z

/lgtm

openshift-bot · 2021-11-04T01:00:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-11-04T01:00:21Z

@openshift-bot: This pull request references Bugzilla bug 2019986, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-04T17:37:15Z

@vojtechszocs: This pull request references Bugzilla bug 2019986, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2019986: Fix dynamic demo plugin build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vojtechszocs · 2021-11-04T17:40:00Z

dynamic-demo-plugin/package.json

@@ -9,13 +9,14 @@
    "build-plugin-sdk": "yarn --cwd ../frontend build-plugin-sdk && rm -rf node_modules/@openshift-console && yarn install --check-files",
    "http-server": "./http-server.sh dist",
    "i18n": "i18next \"src/**/*.{js,jsx,ts,tsx}\" [-oc] -c i18next-parser.config.js",
-    "ts-node": "ts-node -O '{\"module\":\"commonjs\"}' -I '/node_modules/(?!(@openshift-console)/)/'"
+    "ts-node": "ts-node -O '{\"module\":\"commonjs\"}'"


No need to transpile @openshift-console package sources anymore since we're already consuming the distributable plugin SDK packages (sources generated via tsc).

vojtechszocs · 2021-11-04T17:43:35Z

dynamic-demo-plugin/webpack.config.ts

@@ -9,6 +9,7 @@ const CopyWebpackPlugin = require('copy-webpack-plugin');
 const config: webpack.Configuration = {
  mode: 'development',
  context: path.resolve(__dirname, 'src'),
+  entry: {},


This tells webpack "this compilation has no regular entry points" - generation of remote container entry (plugin-entry.js) is handled via ConsoleRemotePlugin.

vojtechszocs · 2021-11-04T17:44:57Z

frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts

@@ -66,7 +66,6 @@ export const getCorePackage: GetPackageDefinition = (
  manifest: {
    name: '@openshift-console/dynamic-plugin-sdk',
    version: sdkPackage.version,
-    type: 'module',


This was causing webpack 5 to resolve ESM module requests more strictly.

https://webpack.js.org/guides/ecma-script-modules/

Imports in ESM are resolved more strictly. Relative requests must include a filename and file extension.

For now, omitting the type field in package manifest. (This impacts imports in SDK source code.)

vojtechszocs · 2021-11-04T17:50:17Z

/bugzilla refresh

openshift-ci · 2021-11-04T17:50:25Z

@vojtechszocs: This pull request references Bugzilla bug 2019986, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2021-11-05T13:38:55Z

@vojtechszocs FYI, needs rebase :/

spadgett

/lgtm

openshift-ci · 2021-11-05T17:31:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rawagner, spadgett, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-11-05T22:02:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-05T22:15:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-06T00:36:05Z

@vojtechszocs: All pull requests linked via external trackers have merged:

openshift/console#10395

Bugzilla bug 2019986 has been moved to the MODIFIED state.

In response to this:

Bug 2019986: Fix dynamic demo plugin build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from rhamilto and spadgett November 3, 2021 18:18

spadgett approved these changes Nov 3, 2021

View reviewed changes

openshift-ci bot assigned spadgett Nov 3, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2021

vojtechszocs changed the title ~~Fix dynamic demo plugin build~~ Bug 2019986: Fix dynamic demo plugin build Nov 3, 2021

openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Nov 3, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 3, 2021

openshift-ci bot assigned rawagner Nov 3, 2021

jcaianirh approved these changes Nov 3, 2021

View reviewed changes

vojtechszocs force-pushed the fix-demo-plugin-build branch from 099fe7d to c721348 Compare November 4, 2021 17:33

openshift-ci bot added component/sdk Related to console-plugin-sdk and removed lgtm Indicates that a PR is ready to be merged. labels Nov 4, 2021

vojtechszocs commented Nov 4, 2021

View reviewed changes

openshift-ci bot requested a review from yapei November 4, 2021 17:50

spadgett mentioned this pull request Nov 4, 2021

Bug 2020001: Update demo dynamic plugin dockerfile to reflect dir structure change #10397

Merged

spadgett added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2021

Fix dynamic demo plugin build

0cfe896

vojtechszocs force-pushed the fix-demo-plugin-build branch from c721348 to 0cfe896 Compare November 5, 2021 17:14

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2021

spadgett approved these changes Nov 5, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2021

openshift-merge-robot merged commit fbfd7f2 into openshift:master Nov 6, 2021

spadgett added this to the v4.10 milestone Dec 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2019986: Fix dynamic demo plugin build #10395

Bug 2019986: Fix dynamic demo plugin build #10395

vojtechszocs commented Nov 3, 2021 •

edited

Loading

spadgett left a comment

openshift-ci bot commented Nov 3, 2021

vojtechszocs commented Nov 3, 2021

openshift-ci bot commented Nov 3, 2021

rawagner commented Nov 3, 2021

openshift-bot commented Nov 4, 2021

openshift-ci bot commented Nov 4, 2021

openshift-ci bot commented Nov 4, 2021

vojtechszocs Nov 4, 2021 •

edited

Loading

vojtechszocs Nov 4, 2021

vojtechszocs Nov 4, 2021

vojtechszocs commented Nov 4, 2021

openshift-ci bot commented Nov 4, 2021

spadgett commented Nov 5, 2021

spadgett left a comment

openshift-ci bot commented Nov 5, 2021

openshift-bot commented Nov 5, 2021

openshift-bot commented Nov 5, 2021

openshift-ci bot commented Nov 6, 2021

Bug 2019986: Fix dynamic demo plugin build #10395

Bug 2019986: Fix dynamic demo plugin build #10395

Conversation

vojtechszocs commented Nov 3, 2021 • edited Loading

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Nov 3, 2021

vojtechszocs commented Nov 3, 2021

openshift-ci bot commented Nov 3, 2021

rawagner commented Nov 3, 2021

openshift-bot commented Nov 4, 2021

openshift-ci bot commented Nov 4, 2021

openshift-ci bot commented Nov 4, 2021

vojtechszocs Nov 4, 2021 • edited Loading

Choose a reason for hiding this comment

vojtechszocs Nov 4, 2021

Choose a reason for hiding this comment

vojtechszocs Nov 4, 2021

Choose a reason for hiding this comment

vojtechszocs commented Nov 4, 2021

openshift-ci bot commented Nov 4, 2021

spadgett commented Nov 5, 2021

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Nov 5, 2021

openshift-bot commented Nov 5, 2021

openshift-bot commented Nov 5, 2021

openshift-ci bot commented Nov 6, 2021

vojtechszocs commented Nov 3, 2021 •

edited

Loading

vojtechszocs Nov 4, 2021 •

edited

Loading