Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odc-6430-Added jan as approver to all plugin folders #10428

Conversation

makambalaji
Copy link
Contributor

Description:
Added jan as approver in OWNERS file of all plugin folders

@makambalaji makambalaji force-pushed the update-owners-for-new-resources branch from 820be1c to 2891a95 Compare November 10, 2021 12:37
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/gitops Related to gitops-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology labels Nov 10, 2021
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 10, 2021
@psrna
Copy link
Contributor

psrna commented Nov 10, 2021

/lgtm

@makambalaji
Copy link
Contributor Author

/verify-owners

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@makambalaji
Copy link
Contributor Author

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 11, 2021
@psrna
Copy link
Contributor

psrna commented Nov 11, 2021

/docs-approved
/px-approved
/qe-approved

@makambalaji makambalaji force-pushed the update-owners-for-new-resources branch from 2891a95 to 622b75a Compare November 12, 2021 08:54
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@makambalaji
Copy link
Contributor Author

Added ppitonak to reviewers list of pipelines plugin folder

@makambalaji
Copy link
Contributor Author

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Nov 12, 2021
@psrna
Copy link
Contributor

psrna commented Nov 12, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makambalaji, psrna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e19195f into openshift:master Nov 12, 2021
@spadgett spadgett added this to the v4.10 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants