Bug 2022446: Fix issue with standalone dashboards (4.9 backport) #10441

SanjalKatiyar · 2021-11-11T16:39:09Z

This is a manual cherry-pick of #10117 and #10362 for release-4.9 branch.

openshift-ci · 2021-11-11T16:39:15Z

@SanjalKatiyar: This pull request references Bugzilla bug 2022446, which is invalid:

expected dependent Bugzilla bug 2008859 to target a release in 4.10.0, but it targets "ODF 4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2022446: Fix issue with standalone dashboards (4.9 backport)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2021-11-12T06:52:58Z

/bugzilla refresh

openshift-ci · 2021-11-12T06:53:05Z

@afreen23: This pull request references Bugzilla bug 2022446, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2006060 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2006060 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23

/lgtm
/label backport-risk-assessed

afreen23 · 2021-11-12T06:58:21Z

/retest-required

SanjalKatiyar · 2021-11-12T06:59:15Z

frontend/packages/ceph-storage-plugin/src/plugin.ts

+      required: [MCG_FLAG],
+      disallowed: [OCS_FLAG, ODF_MODEL_FLAG],
+    },
+  },


I can't remember why I added this. Maybe something was in my mind for 4.10 PR, but, this will not affect this 4.9 BZ. Should I remove this ?

This looks something that would be required for OCS 4.8 support. AFAIK this is required to support OCS 4.8 standalone MCG. MCG standalone in 4.8 doesn't create StorageCluster.

So, it is good to have this fix in this backport PR ? (OCP 4.9 + OCS 4.8 is valid combination)
We can remove this from 4.10 later.

afreen23 · 2021-11-12T07:05:26Z

/lgtm cancel
/approve cancel
Need to review soln based on #10441 (comment)

afreen23 · 2021-11-12T07:06:28Z

/label backport-risk-assessed cancel

afreen23

@bipuladh PTAL

bipuladh · 2021-11-17T06:18:56Z

frontend/packages/ceph-storage-plugin/src/plugin.ts

+      required: [MCG_FLAG],
+      disallowed: [OCS_FLAG, ODF_MODEL_FLAG],
+    },
+  },


This looks something that would be required for OCS 4.8 support. AFAIK this is required to support OCS 4.8 standalone MCG. MCG standalone in 4.8 doesn't create StorageCluster.

SanjalKatiyar · 2021-11-17T06:58:02Z

/test ceph-storage-plugin

afreen23 · 2021-11-23T12:08:40Z

/retest-required
/lgtm

afreen23 · 2021-11-23T12:10:41Z

@SanjalKatiyar please connect with an odf qe to verify this backport Pr .

openshift-ci · 2021-11-23T12:11:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [afreen23,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-11-23T13:43:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

bernerhat · 2021-11-30T08:21:46Z

Have verified the pr using cluster bot and Sanjal's input.

Unfortunately im lacking permissions so i cant mark as cherry-pick-approved

yapei · 2021-11-30T13:43:18Z

adding qe-approved and cherry-pick-approved label according to ^^ comment
/label qe-approved
/label cherry-pick-approved

openshift-ci · 2021-11-30T15:53:38Z

@SanjalKatiyar: All pull requests linked via external trackers have merged:

openshift/console#10441

Bugzilla bug 2022446 has been moved to the MODIFIED state.

In response to this:

Bug 2022446: Fix issue with standalone dashboards (4.9 backport)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fix issue with standalone dashboards (4.9 backport)

f506c77

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 11, 2021

openshift-ci bot requested review from cloudbehl and shyRozen November 11, 2021 16:39

openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Nov 11, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 12, 2021

afreen23 approved these changes Nov 12, 2021

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 12, 2021

openshift-ci bot assigned afreen23 Nov 12, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021

SanjalKatiyar commented Nov 12, 2021

View reviewed changes

openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2021

afreen23 approved these changes Nov 16, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021

bipuladh approved these changes Nov 17, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021

openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Nov 30, 2021

openshift-merge-robot merged commit a771130 into openshift:release-4.9 Nov 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2022446: Fix issue with standalone dashboards (4.9 backport) #10441

Bug 2022446: Fix issue with standalone dashboards (4.9 backport) #10441

SanjalKatiyar commented Nov 11, 2021

openshift-ci bot commented Nov 11, 2021

afreen23 commented Nov 12, 2021

openshift-ci bot commented Nov 12, 2021

afreen23 left a comment

afreen23 commented Nov 12, 2021

SanjalKatiyar Nov 12, 2021 •

edited

Loading

bipuladh Nov 17, 2021

SanjalKatiyar Nov 17, 2021 •

edited

Loading

afreen23 commented Nov 12, 2021

afreen23 commented Nov 12, 2021

afreen23 left a comment

bipuladh Nov 17, 2021

SanjalKatiyar commented Nov 17, 2021

afreen23 commented Nov 23, 2021

afreen23 commented Nov 23, 2021

openshift-ci bot commented Nov 23, 2021

openshift-bot commented Nov 23, 2021

bernerhat commented Nov 30, 2021

yapei commented Nov 30, 2021

openshift-ci bot commented Nov 30, 2021

Bug 2022446: Fix issue with standalone dashboards (4.9 backport) #10441

Bug 2022446: Fix issue with standalone dashboards (4.9 backport) #10441

Conversation

SanjalKatiyar commented Nov 11, 2021

openshift-ci bot commented Nov 11, 2021

afreen23 commented Nov 12, 2021

openshift-ci bot commented Nov 12, 2021

afreen23 left a comment

Choose a reason for hiding this comment

afreen23 commented Nov 12, 2021

SanjalKatiyar Nov 12, 2021 • edited Loading

Choose a reason for hiding this comment

bipuladh Nov 17, 2021

Choose a reason for hiding this comment

SanjalKatiyar Nov 17, 2021 • edited Loading

Choose a reason for hiding this comment

afreen23 commented Nov 12, 2021

afreen23 commented Nov 12, 2021

afreen23 left a comment

Choose a reason for hiding this comment

bipuladh Nov 17, 2021

Choose a reason for hiding this comment

SanjalKatiyar commented Nov 17, 2021

afreen23 commented Nov 23, 2021

afreen23 commented Nov 23, 2021

openshift-ci bot commented Nov 23, 2021

openshift-bot commented Nov 23, 2021

bernerhat commented Nov 30, 2021

yapei commented Nov 30, 2021

openshift-ci bot commented Nov 30, 2021

SanjalKatiyar Nov 12, 2021 •

edited

Loading

SanjalKatiyar Nov 17, 2021 •

edited

Loading