Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2023090: [e2e][automation] Examples of Import URL for VM templates #10456

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

lkladnit
Copy link
Contributor

@lkladnit lkladnit commented Nov 14, 2021

Tests checking the content of the hints with example registry URLs for VM bootsources.

Story: [Cypress tests for CNV-14292: add TC/automation for fixed bugs
Bug 1908169 - (verify examples for URL/Registry for RHEL/Fedora/Centos/Windows)
Polarion doc
[Polarion Testcase: CNV-7509 - Examples of Import URL for VM templates ](https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-7509)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2021

@lkladnit: This pull request references Bugzilla bug 2023090, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request.

In response to this:

Bug 2023090: [e2e][automation] Examples of Import URL for VM templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 14, 2021
@gouyang
Copy link
Contributor

gouyang commented Nov 17, 2021

I think we should check the href of URL source and the example description of Registry source.

@lkladnit
Copy link
Contributor Author

/retest

@lkladnit
Copy link
Contributor Author

/test kubevirt-plugin

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2021
@lkladnit
Copy link
Contributor Author

/retest

1 similar comment
@lkladnit
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2021
@lkladnit
Copy link
Contributor Author

/retest

@lkladnit lkladnit force-pushed the url_examples branch 2 times, most recently from 40b18c4 to 2eac57b Compare November 24, 2021 07:15
@lkladnit
Copy link
Contributor Author

/retest

@lkladnit
Copy link
Contributor Author

/retest

@lkladnit
Copy link
Contributor Author

/retest

1 similar comment
@lkladnit
Copy link
Contributor Author

/retest

@gouyang
Copy link
Contributor

gouyang commented Nov 25, 2021

/test e2e-gcp-console

@lkladnit
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2021

@lkladnit: This pull request references Bugzilla bug 2023090, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request.

In response to this:

Bug 2023090: [e2e][automation] Examples of Import URL for VM templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lkladnit
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2021

@lkladnit: This pull request references Bugzilla bug 2023090, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request.

In response to this:

Bug 2023090: [e2e][automation] Examples of Import URL for VM templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lkladnit
Copy link
Contributor Author

/retest
\

@lkladnit
Copy link
Contributor Author

@gouyang , It passed all the tests, can it be merged?

@gouyang
Copy link
Contributor

gouyang commented Dec 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2021
@gouyang
Copy link
Contributor

gouyang commented Dec 20, 2021

@pcbailey please review

@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, lkladnit, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@lkladnit: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2098390 into openshift:master Dec 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@lkladnit: All pull requests linked via external trackers have merged:

Bugzilla bug 2023090 has been moved to the MODIFIED state.

In response to this:

Bug 2023090: [e2e][automation] Examples of Import URL for VM templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants