Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 2024206: Fix resource metrics 403 errors for project admin users #10496

Merged
merged 1 commit into from Dec 3, 2021
Merged

[release-4.8] Bug 2024206: Fix resource metrics 403 errors for project admin users #10496

merged 1 commit into from Dec 3, 2021

Conversation

TheRealJon
Copy link
Member

Manual cherry-pick of #10344

@TheRealJon
Bug 2015806: Fix resource metrics 403 errors for project admin users
5686bf4 
- Add namespace prop to QueryBrowser in ResourceMetricsDashboardCard component, which causes all queries to be run as namespace-scoped thanos tenancy requests.
- Remove namespace from all PromQL queries defined in `frontend/packages/console-shared/src/promql/resource-metrics.ts`. These queries will always be run as namespace-scoped tenancy endpoint requests, so including the namespace in the PromQL query is redundant.
- Adjust dev console top workload metrics "Recieve bandwidth" PromQL query to use `namespace=` rather than `namespace=~`. This was causing a `400: Bad Request` on tenancy requests witn `namespace` in the URL query parameters.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@TheRealJon: This pull request references Bugzilla bug 2024206, which is invalid:

  • expected dependent Bugzilla bug 2015806 to target a release in 4.9.0, 4.9.z, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[Release 4.8] Bug 2024206: Fix resource metrics 403 errors for project admin users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Nov 17, 2021
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/shared Related to console-shared labels Nov 17, 2021
@TheRealJon
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@TheRealJon: This pull request references Bugzilla bug 2024206, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2020000 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2020000 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 17, 2021
@openshift-ci openshift-ci bot requested a review from yapei November 17, 2021 15:53
@TheRealJon TheRealJon changed the title [Release 4.8] Bug 2024206: Fix resource metrics 403 errors for project admin users [release-4.8] Bug 2024206: Fix resource metrics 403 errors for project admin users Nov 17, 2021
@TheRealJon
Copy link
Member Author

/retest

@kdoberst
Copy link
Contributor

/approved

@kdoberst
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 23, 2021
@kdoberst
Copy link
Contributor

/approve

@yapei
Copy link
Contributor

yapei commented Dec 1, 2021

@schituku Could you help verify the PR?

@schituku
Copy link

schituku commented Dec 2, 2021

/lgtm

@schituku
Copy link

schituku commented Dec 2, 2021

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 2, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@yapei
Copy link
Contributor

yapei commented Dec 2, 2021

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 2, 2021
@zherman0
Copy link
Member

zherman0 commented Dec 3, 2021

/approved

spadgett
spadgett approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdoberst, schituku, spadgett, TheRealJon, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 622bf63 into openshift:release-4.8 Dec 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

@TheRealJon: All pull requests linked via external trackers have merged:

Bugzilla bug 2024206 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 2024206: Fix resource metrics 403 errors for project admin users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov jerolimov mentioned this pull request Jan 6, 2022
Merged
@TheRealJon TheRealJon deleted the 2024206 branch January 27, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@zherman0 zherman0 zherman0 approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@rottencandy rottencandy Awaiting requested review from rottencandy

@yapei yapei Awaiting requested review from yapei

Assignees

@schituku schituku

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality component/dev-console Related to dev-console component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@TheRealJon @kdoberst @yapei @schituku @zherman0 @spadgett @openshift-merge-robot