Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation for Observe page features #10566

Merged

Conversation

jrichter1
Copy link
Contributor

@jrichter1 jrichter1 commented Nov 29, 2021

Epic: https://issues.redhat.com/browse/ODC-3698
Story: https://issues.redhat.com/browse/ODC-6384

Checks for approving Epic scenarios Automation PR:

  • Execute the @to-do tagged gherkin scripts manually
  • Convert the @to-do gherkin scripts to cypress automation scripts
  • Once scripts are automated, replace tag @to-do with @epic-number
  • Execute the scripts in Remote cluster

Test Setup
Check the TAGS in frontend/packages/topology/integration-tests/cypress.json file be: ""(@odc-3698) and not (@Manual or @to-do or @un-verified or @broken-test)"",

Command to execute:

Run a cluster locally and execute ./test-cypress.sh -p dev-console simultaneously

Execute the following files:

  • changing-context-monitoring-dashboard.feature
  • dashboard-display.feature
  • topology-sidebar-actions.feature

Browsers
Chrome 90

Screenshots
m01
m02
m04

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/monitoring Related to monitoring component/topology Related to topology labels Nov 29, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 24, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2022
@jrichter1 jrichter1 changed the title Automation for Consolidate core dashboard with dev perspective Automation for Observe page features Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@jrichter1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sanketpathak
Copy link
Contributor

/lgtm
Screenshot from 2022-01-27 15-38-59

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@sanketpathak
Copy link
Contributor

/cc @jerolimov
Can you approve the pr

@openshift-ci openshift-ci bot requested a review from jerolimov January 27, 2022 11:44
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general lgtm. Code changes only added some data-test attributes.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jrichter1, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@sanketpathak
Copy link
Contributor

This PR only affects our e2e tests.

/label qe-approved
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit d9e89b2 into openshift:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants