-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1992509: Could not customize boot source due to source PVC not found #10613
Bug 1992509: Could not customize boot source due to source PVC not found #10613
Conversation
@avivtur: This pull request references Bugzilla bug 1992509, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
frontend/packages/kubevirt-plugin/src/types/api/V1ResourceRequirements.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
/lgtm |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@avivtur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@avivtur: All pull requests linked via external trackers have merged: Bugzilla bug 1992509 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1992509
https://issues.redhat.com/browse/OCPBUGSM-33213
Analysis / Root cause:
when customizing a boot source for a template, we create a temporary VM
that creates a DV that his owner is the VM.
once we delete the temporary VM, the DV is also being deleted, and the source is not available.
Solution Description:
changing owner reference of DV created by the VM to the created template,
and changing the DV size the size of PVC cloned from to get inline with: #10477
Screen shots / Gifs for design review:
Before: Please follow the attachment file of BZ link provided above
After:
Signed-off-by: Aviv Turgeman aturgema@redhat.com