Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2039315: Filter superseded helm secrets and fix firehose to support partial metadata #10812

Merged
merged 2 commits into from Jan 20, 2022
Merged

Bug 2039315: Filter superseded helm secrets and fix firehose to support partial metadata #10812

merged 2 commits into from Jan 20, 2022

Conversation

rohitkrai03
Copy link
Contributor

@rohitkrai03 rohitkrai03 commented Jan 11, 2022 •
edited

Note - This is a follow up PR to #10754 and second part of the fix we need for https://bugzilla.redhat.com/show_bug.cgi?id=1999796.

Fixes: https://issues.redhat.com/browse/OCPBUGSM-39230

Analysis / Root cause: Helm release list page and topology was fetching all the secrets even though we only need latest secrets that are actually deployed.

Solution Description:

  • Filter out superseded secrets using label selector.
  • Add support for partial metadata in firehose for topology.

Screen shots / Gifs for design review: No UI change.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@rohitkrai03: This pull request references Bugzilla bug 2039315, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2039315: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 11, 2022
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/helm Related to helm-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@rohitkrai03: This pull request references Bugzilla bug 2039315, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2039315: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@rohitkrai03: This pull request references Bugzilla bug 2039315, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2039315: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohitkrai03 rohitkrai03 mentioned this pull request Jan 11, 2022
Merged
3 tasks
@rohitkrai03
Copy link
Contributor Author

/retest

1 similar comment
@jerolimov
Copy link
Member

/retest

jerolimov
jerolimov approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. This is a big topology improvement 👍 I just started adding this and looked for the other partial metadata PR when founding this. Tested this locally and works fine for me 👍

For my test project with 3 deployments and 1 simple helm chart, it reduces the transferred content from 75 kb to 1.7 kb.

For my load test with 300+ secrets of different sizes, it reduces the transferred size from 13,2 mb to 1 kb -- sure, because I don't include any helm tests here at the moment and a lot of bloated secrets.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jerolimov
Copy link
Member

/lgtm cancel

@rohitkrai03 looks like this crashs the topology in our test cases. I will also take a look

image

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jerolimov
Copy link
Member

Cypress tests still do not pass. Stop CI server from running tests again and again.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@rohitkrai03
Copy link
Contributor Author

/hold cancel

Pushed a fix to the e2e test failure.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2022
jerolimov
jerolimov approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and it still works fine 👍

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@rohitkrai03: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 939e234 into openshift:master Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@rohitkrai03: All pull requests linked via external trackers have merged:

Bugzilla bug 2039315 has been moved to the MODIFIED state.

In response to this:

Bug 2039315: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/cherry-pick release-4.9

@openshift-cherrypick-robot
Copy link

@jerolimov: #10812 failed to apply on top of branch "release-4.9":

Applying: Filter out superseded helm release secrets and fix firehose to support partial metadata
Using index info to reconstruct a base tree...
M	frontend/packages/helm-plugin/console-extensions.json
M	frontend/packages/helm-plugin/src/components/list-page/HelmReleaseList.tsx
M	frontend/packages/helm-plugin/src/topology/helmResources.ts
M	frontend/public/components/utils/firehose.jsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/utils/firehose.jsx
Auto-merging frontend/packages/helm-plugin/src/topology/helmResources.ts
CONFLICT (content): Merge conflict in frontend/packages/helm-plugin/src/topology/helmResources.ts
Auto-merging frontend/packages/helm-plugin/src/components/list-page/HelmReleaseList.tsx
CONFLICT (content): Merge conflict in frontend/packages/helm-plugin/src/components/list-page/HelmReleaseList.tsx
Auto-merging frontend/packages/helm-plugin/console-extensions.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Filter out superseded helm release secrets and fix firehose to support partial metadata
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov added a commit to jerolimov/console that referenced this pull request Jan 24, 2022
@jerolimov
Filter superseded helm secrets and fix firehose to support partial me…
dd84521 
…tadata

Backport of openshift#10812
jerolimov added a commit to jerolimov/console that referenced this pull request Jan 24, 2022
@jerolimov
Filter superseded helm secrets and fix firehose to support partial me…
08f9df6 
…tadata

Backport of openshift#10812
jerolimov added a commit to jerolimov/console that referenced this pull request Jan 24, 2022
@jerolimov
Filter superseded helm secrets and fix firehose to support partial me…
a1c95ef 
…tadata

Backport of openshift#10812
@jerolimov jerolimov mentioned this pull request Jan 24, 2022
Merged
jerolimov added a commit to jerolimov/console that referenced this pull request Jan 26, 2022
@jerolimov
Filter superseded helm secrets and fix firehose to support partial me…
7639aed 
…tadata

Backport of openshift#10812
@jerolimov jerolimov mentioned this pull request Jan 26, 2022
Merged
jerolimov added a commit to jerolimov/console that referenced this pull request Feb 16, 2022
@jerolimov
Filter superseded helm secrets and fix firehose to support partial me…
da142d0 
…tadata

Backport of openshift#10812
@jerolimov jerolimov mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/helm Related to helm-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rohitkrai03 @jerolimov @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot