Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 2055411: Filter superseded helm secrets and fix firehose to support partial metadata #11078

Merged

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Feb 16, 2022

This is a manually cherry-pick/backport of #10936, this PR depends on #11077 (first commit) that should be reviewed/merged first.

4.10: https://bugzilla.redhat.com/show_bug.cgi?id=2039315
4.9: https://bugzilla.redhat.com/show_bug.cgi?id=2044292
4.8: https://bugzilla.redhat.com/show_bug.cgi?id=2046215
4.7: https://bugzilla.redhat.com/show_bug.cgi?id=2055411

Merge notes
Just need to add one extra type definition to support operator "NotEquals".

On release-4.7 branch:
image

With this PR:
image

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@jerolimov: This pull request references Bugzilla bug 2046215, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "4.8.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected dependent Bugzilla bug 2044292 to target a release in 4.8.0, 4.8.z, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 2046215: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 16, 2022
@jerolimov jerolimov changed the title [release-4.7] Bug 2046215: Filter superseded helm secrets and fix firehose to support partial metadata [release-4.7] Bug 2055411: Filter superseded helm secrets and fix firehose to support partial metadata Feb 16, 2022
@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@jerolimov: This pull request references Bugzilla bug 2055411, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2046215 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2046215 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.7] Bug 2055411: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Feb 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@jerolimov: This pull request references Bugzilla bug 2055411, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2046215 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2046215 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.7] Bug 2055411: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@jerolimov: This pull request references Bugzilla bug 2055411, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2046215 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2046215 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.7] Bug 2055411: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

@jerolimov: GitHub didn't allow me to request PR reviews from the following users: SparshKesari.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @karthikjeeyar @sanketpathak @SparshKesari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member Author

/assign @christianvogt

@christianvogt
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@karthikjeeyar
Copy link
Contributor

Verified on cluster
image

/lgtm
/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

@karthikjeeyar: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

Verified on cluster
image

/lgtm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jerolimov, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 2, 2022
@jerolimov
Copy link
Member Author

Verified on cluster image

/cc @sanketpathak @jrichter1

@openshift-ci openshift-ci bot requested a review from jrichter1 March 3, 2022 22:11
@sanketpathak
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c03c2c0 into openshift:release-4.7 Mar 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

@jerolimov: An error was encountered updating to the MODIFIED state for bug 2055411 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. code 410: You must log in before using this part of Red Hat Bugzilla.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] Bug 2055411: Filter superseded helm secrets and fix firehose to support partial metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants