-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2044803: buttons styles aligned #10935
Bug 2044803: buttons styles aligned #10935
Conversation
@upalatucci: This pull request references Bugzilla bug 2044803, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@upalatucci: This pull request references Bugzilla bug 2044803, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@upalatucci: This pull request references Bugzilla bug 2044803, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@yaacov: This pull request references Bugzilla bug 2044803, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@upalatucci: This pull request references Bugzilla bug 2044803, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
198524a
to
2c9c742
Compare
2c9c742
to
4949605
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@upalatucci: This pull request references Bugzilla bug 2044803, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Hi @bgaydosrh or @lmandavi@redhat.com, would you please review the mentioned changes? |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest |
Hi @yfrimanm and @upalatucci - No problem, I understand Pattern Fly may have limitations with things like the expander. I see no problems with the presentations on the headers. The only question would be on "Network interfaces" --- if you want to cap both words or not. Doc follows strict sentence-style casing (which is first word only) but UI may be different. The most important thing is that you follow whatever style you are adhering to currently (so the user sees the same type of capitalization everywhere), and even that is hardly a showstopper. Make sense? If not, let me know. Thanks, |
Thank you @robert Gaydos ***@***.***> this makes perfect sense to
me as well.
…On Thu, Jan 27, 2022 at 6:24 PM Bob Gaydos ***@***.***> wrote:
Hi @yfrimanm <https://github.com/yfrimanm> and @upalatucci
<https://github.com/upalatucci> - No problem, I understand Pattern Fly
may have limitations with things like the expander.
I see no problems with the presentations on the headers. The only question
would be on "Network interfaces" --- if you want to cap both words or not.
Doc follows strict sentence-style casing (which is first word only) but UI
may be different. The most important thing is that you follow whatever
style you are adhering to currently (so the user sees the same type of
capitalization everywhere), and even that is hardly a showstopper. Make
sense? If not, let me know.
Thanks,
Bob
—
Reply to this email directly, view it on GitHub
<#10935 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKUDFDGF6IJYVJQJAREP3C3UYFWTFANCNFSM5M2XPSMA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/bugzilla refresh The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity. |
@openshift-bot: This pull request references Bugzilla bug 2044803, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@upalatucci: This pull request references Bugzilla bug 2044803, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2044803, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2044803, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2044803, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@upalatucci: This pull request references Bugzilla bug 2044803, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2044803 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@upalatucci: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fix:
https://bugzilla.redhat.com/show_bug.cgi?id=2044803
Analysis / Root cause:
Buttons with different styles applied across tabs
Solution Description:
Apply the same style on all top page buttons across tabs
Before:
After: