[release-4.7] Bug 2049313: Topology performance: Do not fetch HPA for each Deployment (Pod Ring)

[openshift-cherrypick-robot]

This is an automated cherry-pick of #10931

/assign jerolimov

[openshift-ci]

@openshift-cherrypick-robot: Bugzilla bug 2046043 has been cloned as Bugzilla bug 2049313. Retitling PR to link against new bug.
/retitle [release-4.7] [release-4.8] Bug 2049313: Topology performance: Do not fetch HPA for each Deployment (Pod Ring)

In response to this:

[release-4.7] [release-4.8] Bug 2046043: Topology performance: Do not fetch HPA for each Deployment (Pod Ring)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2049313, which is invalid:

• expected dependent Bugzilla bug 2046043 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] [release-4.8] Bug 2049313: Topology performance: Do not fetch HPA for each Deployment (Pod Ring)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/retitle [release-4.7] Bug 2049313: Topology performance: Do not fetch HPA for each Deployment (Pod Ring)
/label backport-risk-assessed
/cc @jerolimov @rottencandy @sanketpathak

[rottencandy]

Tested using cluster-bot.
/lgtm

[jerolimov]

Looks like this change is not enough for 4.7. I will take a look next week how we can improve and backport this for 4.7.

/wip
/hold

[jerolimov]

Hey @rottencandy, I tried this now locally and now again on a cluster bot, and yeah, it looks like it works fine. I don't know why I saw this HPA the last time... 🤷‍♂️

A 4.7 cluster without this change:

before.mp4

On localhost:

localhost.mp4

And finally the fix with this PR (started via cluster bot):

with-pr.mp4

/unhold
/approve
/cc @sanketpathak @jrichter1

[jerolimov]

/bugzilla refresh

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2049313, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2046043 is in the state RELEASE_PENDING, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2046043 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/assign @christianvogt

[christianvogt]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jerolimov, openshift-cherrypick-robot, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sanketpathak]

/label cherry-pick-approved

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/console#10991

Bugzilla bug 2049313 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 2049313: Topology performance: Do not fetch HPA for each Deployment (Pod Ring)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.