Bug 1666231 - Update Cluster Settings page for ClusterVersion API changes #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
There was a problem hiding this comment.
@spadgett should STATE column be STATUS? And should we have icons with the associated status values?
Good question. The values are "Completed" or "Partial," which is different than what we show for "Update Status" above. The API field is |
|
jenkins rebuild |
1 similar comment
|
jenkins rebuild |
openshift-ci-robot
added
the
needs-rebase
spadgett
force-pushed
the
cluster-version
branch
from
e9188c8
to
7652758
Compare
openshift-ci-robot
removed
the
needs-rebase
spadgett
force-pushed
the
cluster-version
branch
from
7652758
to
4635b96
Compare
|
/test all |
spadgett
force-pushed
the
cluster-version
branch
from
4635b96
to
a0a2d60
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/refresh |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
openshift-ci-robot
added
the
needs-rebase
…nges Change "Current Version" label to "Desired Version," which is more accurate. Add an "Update History" table so that it's possible to see the last completed update version. https://bugzilla.redhat.com/show_bug.cgi?id=1666231
spadgett
force-pushed
the
cluster-version
branch
from
a0a2d60
to
bfad801
Compare
openshift-ci-robot
removed
lgtm
|
@TheRealJon rebased, ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change "Current Version" label to "Desired Version," which is more
accurate. Add an "Update History" table so that it's possible to see the
last completed update version.
https://bugzilla.redhat.com/show_bug.cgi?id=1666231
/hold
cc @smarterclayton @openshift/team-ux-review
/assign @TheRealJon