[release-4.10] Bug 2054757: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

[openshift-cherrypick-robot]

This is an automated cherry-pick of #11001

/assign jerolimov

[openshift-ci]

@openshift-cherrypick-robot: Bugzilla bug 2053685 has been cloned as Bugzilla bug 2054757. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2054757: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

In response to this:

[release-4.10] Bug 2053685: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2054757, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2053685 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Bugzilla bug 2053685 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.10] Bug 2054757: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vikram-raj]

Verified it on a cluster with 100 Deployments and 100 Pods in topology.

[vikram-raj]

/lgtm

[jerolimov]

Tested it on my local cluster and from what I've tested it still works.

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, openshift-cherrypick-robot, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerolimov]

/cherry-pick release-4.9

[openshift-cherrypick-robot]

@jerolimov: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

@spadgett Can we get this merge into 4.10 so that we can backport it to older versions soon? Just asking, otherwise z steam will open next week hopefully, right?

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sanketpathak]

/label cherry-pick-approved

[jerolimov]

/label backport-risk-assessed

[openshift-ci]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/console#11059

Bugzilla bug 2054757 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2054757: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jerolimov: #11059 failed to apply on top of branch "release-4.9":

Applying: Add unit tests for the status quo
Applying: Performance improvement by reducing rerenderings and deep toJSON() calls
Using index info to reconstruct a base tree...
A	frontend/packages/console-dynamic-plugin-sdk/src/utils/k8s/hooks/k8s-watcher.ts
M	frontend/public/components/utils/firehose.jsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/utils/firehose.jsx
CONFLICT (content): Merge conflict in frontend/public/components/utils/firehose.jsx
CONFLICT (modify/delete): frontend/packages/console-dynamic-plugin-sdk/src/utils/k8s/hooks/k8s-watcher.ts deleted in HEAD and modified in Performance improvement by reducing rerenderings and deep toJSON() calls. Version Performance improvement by reducing rerenderings and deep toJSON() calls of frontend/packages/console-dynamic-plugin-sdk/src/utils/k8s/hooks/k8s-watcher.ts left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Performance improvement by reducing rerenderings and deep toJSON() calls
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.