Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.10] Bug 2059848: fix duplicate edit app action on installing virtualization operator #11121

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #11076

/assign debsmita1

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

@openshift-cherrypick-robot: Bugzilla bug 2052956 has been cloned as Bugzilla bug 2059848. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2059848: fix duplicate edit app action on installing virtualization operator

In response to this:

[release-4.10] Bug 2052956: fix duplicate edit app action on installing virtualization operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] Bug 2052956: fix duplicate edit app action on installing virtualization operator [release-4.10] Bug 2059848: fix duplicate edit app action on installing virtualization operator Mar 2, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2059848, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2052956 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2052956 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

[release-4.10] Bug 2059848: fix duplicate edit app action on installing virtualization operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin component/topology Related to topology labels Mar 2, 2022
@debsmita1
Copy link
Contributor

verified on dev cluster
Peek 2022-03-02 15-52

@nemesis09
Copy link
Contributor

verified on openshift 4.10.0-rc.6. works as expected.
/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@nemesis09
Copy link
Contributor

/assign @rohitkrai03

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nemesis09, openshift-cherrypick-robot, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@jerolimov
Copy link
Member

/uncc
/label backport-risk-assessed
/cc @jrichter1

This PR will needs cherrypick-approval / qe-approval when 4.10 is released. A video is available above in #11121 (comment)

@openshift-ci openshift-ci bot requested review from jrichter1 and removed request for jerolimov March 9, 2022 09:45
@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 9, 2022
@jrichter1
Copy link
Contributor

/qe-approved
/cherry-pick-approved

@jerolimov
Copy link
Member

/qe-approved /cherry-pick-approved

Can I do this? :P
/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@jerolimov: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/qe-approved /cherry-pick-approved

Can I do this? :P
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@debsmita1
Copy link
Contributor

/assign @jrichter1

@sanketpathak
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3db6521 into openshift:release-4.10 Mar 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2059848 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2059848: fix duplicate edit app action on installing virtualization operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/kubevirt Related to kubevirt-plugin component/topology Related to topology lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants