Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dark theme]Fix namespaced pages, add page and catalogs page #11144

Merged
merged 1 commit into from
Mar 8, 2022
Merged

[Dark theme]Fix namespaced pages, add page and catalogs page #11144

merged 1 commit into from
Mar 8, 2022

Conversation

vikram-raj
Copy link
Member

Fixes: https://issues.redhat.com/browse/ODC-6489

Description:

  • Fix Namespaced pages in ODC
  • Fix user preferences page
  • Fix Catalogs page
  • Replace SVG icons with PF icons on add page.

Screenshots:
image

image

image

image

@openshift-ci openshift-ci bot requested review from andybraren and kyoto March 7, 2022 10:24
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/shared Related to console-shared labels Mar 7, 2022
@vikram-raj
Copy link
Member Author

/cc @sg00dwin
/cc @mattnolting

@openshift-ci openshift-ci bot requested a review from sg00dwin March 7, 2022 10:25
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2022

@vikram-raj: GitHub didn't allow me to request PR reviews from the following users: mattnolting.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @sg00dwin
/cc @mattnolting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/cc @jerolimov

@openshift-ci openshift-ci bot requested a review from jerolimov March 7, 2022 10:26
spadgett
spadgett approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
mattnolting
mattnolting approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

spadgett
spadgett approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@mattnolting
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2022

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vikram-raj
Copy link
Member Author

Propagate from epic:
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Mar 8, 2022
@vikram-raj
Copy link
Member Author

Hi @spadgett , Do we have a QE contact who will review dark theme PRs and will add qe-approved label?

jerolimov
jerolimov approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on slack, the helm and serverless icons are still black. But we can follow up on this in another PR. Up to you @vikram-raj => The are external svg files. We will follow up on this when searching for a more generic icon solution.

image

@jerolimov
Copy link
Member

Hi @spadgett , Do we have a QE contact who will review dark theme PRs and will add qe-approved label?

For ODC we decided that any dev can add this label if the PR was tested on a cluster bot instance and that QE will check the epic later. For this CSS change, I think it's fine to test this locally with a clean rebuild.

Let's move fast and break things here :P

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, mattnolting, spadgett, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9a9df3c into openshift:master Mar 8, 2022
@vikram-raj vikram-raj deleted the odc-6489 branch March 9, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@spadgett spadgett spadgett approved these changes

@mattnolting mattnolting mattnolting approved these changes

@andybraren andybraren Awaiting requested review from andybraren

@kyoto kyoto Awaiting requested review from kyoto

@sg00dwin sg00dwin Awaiting requested review from sg00dwin

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vikram-raj @openshift-bot @mattnolting @jerolimov @spadgett @openshift-merge-robot